Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace few uses of CPPUNIT_TEST_FAIL with just CPPUNIT_TEST

Browse Source 
Use positive tests really checking for whatever we want to check (that
the stream is not seekable in this particular case) instead of just
checking that the test fails, for whatever reason -- which might not be
at all the reason for which we expect it to fail.
This commit is contained in:
Vadim Zeitlin
2017-10-31 22:04:12 +01:00
parent b8c9cd3528
commit c54b611093
2 changed files with 28 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tests/streams/zlibstream.cpp
View File

@@ -46,13 +46,13 @@ public:
CPPUNIT_TEST_SUITE(zlibStream);
// Base class stream tests the zlibstream supports.
CPPUNIT_TEST_FAIL(Input_GetSize);
CPPUNIT_TEST(Input_GetSizeFail);
CPPUNIT_TEST(Input_GetC);
CPPUNIT_TEST(Input_Read);
CPPUNIT_TEST(Input_Eof);
CPPUNIT_TEST(Input_LastRead);
CPPUNIT_TEST(Input_CanRead);
CPPUNIT_TEST_FAIL(Input_SeekI);
CPPUNIT_TEST(Input_SeekIFail);
CPPUNIT_TEST(Input_TellI);
CPPUNIT_TEST(Input_Peek);
CPPUNIT_TEST(Input_Ungetch);
@@ -60,7 +60,7 @@ public:
CPPUNIT_TEST(Output_PutC);
CPPUNIT_TEST(Output_Write);
CPPUNIT_TEST(Output_LastWrite);
CPPUNIT_TEST_FAIL(Output_SeekO);
CPPUNIT_TEST(Output_SeekOFail);
CPPUNIT_TEST(Output_TellO);
// Other test specific for zlib stream test case.