Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimize wxTextCtrl::GetLastPosition()

Browse Source 
It's better to call one API instead of four.
This commit is contained in:
Artur Wieczorek
2017-09-01 09:03:21 +02:00
parent 4fc8753285
commit c51dd81db6
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/msw/textctrl.cpp
View File

@@ -1334,12 +1334,19 @@ wxTextPos wxTextCtrl::GetLastPosition() const
{ {
if ( IsMultiLine() ) if ( IsMultiLine() )
{ {
int numLines = GetNumberOfLines(); #if wxUSE_RICHEDIT
long posStartLastLine = XYToPosition(0, numLines - 1); if ( IsRich() )
{
long lenLastLine = GetLengthOfLineContainingPos(posStartLastLine); GETTEXTLENGTHEX gtl;
gtl.flags = GTL_NUMCHARS | GTL_PRECISE;
return posStartLastLine + lenLastLine; gtl.codepage = GetRichVersion() > 1 ? 1200 : CP_ACP;
return ::SendMessage(GetHwnd(), EM_GETTEXTLENGTHEX, (WPARAM)&gtl, 0);
}
else
#endif // wxUSE_RICHEDIT
{
return ::GetWindowTextLength(GetHwnd());
}
} }
return wxTextEntry::GetLastPosition(); return wxTextEntry::GetLastPosition();