Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-Authored-By: VZ <vz-github@zeitlins.org>
This commit is contained in:
Tobias Taschner
2020-01-15 15:33:38 +01:00
parent 049d253a85
commit c3f0b7a6cb
4 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
include/wx/setup_inc.h
View File

@@ -758,7 +758,7 @@
// Use the Edge (Chromium) wxWebView backend (Requires WebView2 SDK) // Use the Edge (Chromium) wxWebView backend (Requires WebView2 SDK)
// //
// Default is 0 // Default is 0 because WebView2 is not always available, set it to 1 if you do have it.
// //
// Recommended setting: 1 when building for Windows with WebView2 SDK // Recommended setting: 1 when building for Windows with WebView2 SDK
#define wxUSE_WEBVIEW_EDGE 0 #define wxUSE_WEBVIEW_EDGE 0
@@ -1556,4 +1556,3 @@
#define wxUSE_THEME_MONO 0 #define wxUSE_THEME_MONO 0
#define wxUSE_THEME_WIN32 0 #define wxUSE_THEME_WIN32 0

2
interface/wx/webview.h
View File

@@ -449,7 +449,7 @@ public:
wxSharedPtr<wxWebViewFactory> factory); wxSharedPtr<wxWebViewFactory> factory);
/** /**
Allows to check if a specific backend is currently available Allows to check if a specific backend is currently available.
@since 3.1.4 @since 3.1.4
*/ */

2
src/common/webview.cpp
View File

@@ -91,7 +91,7 @@ void wxWebView::RegisterFactory(const wxString& backend,
bool wxWebView::IsBackendAvailable(const wxString& backend) bool wxWebView::IsBackendAvailable(const wxString& backend)
{ {
wxStringWebViewFactoryMap::iterator iter = FindFactory(backend); wxStringWebViewFactoryMap::iterator iter = FindFactory(backend);
return (iter != m_factoryMap.end()); return iter != m_factoryMap.end();
} }
// static // static

4
src/msw/webview_edge.cpp
View File

@@ -1,5 +1,5 @@
///////////////////////////////////////////////////////////////////////////// /////////////////////////////////////////////////////////////////////////////
// Name: source/msw/webview_edge.cpp // Name: src/msw/webview_edge.cpp
// Purpose: wxMSW Edge Chromium wxWebView backend implementation // Purpose: wxMSW Edge Chromium wxWebView backend implementation
// Author: Markus Pingel // Author: Markus Pingel
// Created: 2019-12-15 // Created: 2019-12-15
@@ -62,7 +62,7 @@ bool wxWebViewEdge::IsAvailable()
ms_isAvailable = 1; ms_isAvailable = 1;
} }
return (ms_isAvailable == 1); return ms_isAvailable == 1;
} }
bool wxWebViewEdge::Initialize() bool wxWebViewEdge::Initialize()