Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

avoid null pointer dereference in DoGetClientSize

Browse Source 
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@41139 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Paul Cornett
2006-09-10 20:50:58 +00:00
parent fe92a9d685
commit c1fa6f5245
1 changed files with 24 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/gtk/frame.cpp
View File

@@ -10,40 +10,23 @@
// For compilers that support precompilation, includes "wx.h".
#include "wx/wxprec.h"
// ============================================================================
// declarations
// ============================================================================
// ----------------------------------------------------------------------------
// headers
// ----------------------------------------------------------------------------
#include "wx/frame.h"
#ifndef WX_PRECOMP
#include "wx/app.h"
#include "wx/dcclient.h"
#include "wx/menu.h"
#include "wx/dialog.h"
#include "wx/control.h"
#include "wx/toolbar.h"
#include "wx/statusbr.h"
#endif // WX_PRECOMP
#include <glib.h>
#include "wx/gtk/private.h"
#include <gdk/gdkkeysyms.h>
#include <gdk/gdkx.h>
#include "wx/gtk/win_gtk.h"
// ----------------------------------------------------------------------------
// constants
// ----------------------------------------------------------------------------
const int wxSTATUS_HEIGHT = 25;
const int wxPLACE_HOLDER = 0;
static const int wxSTATUS_HEIGHT = 25;
static const int wxPLACE_HOLDER = 0;
// ----------------------------------------------------------------------------
// event tables
@@ -252,6 +235,7 @@ void wxFrame::DoGetClientSize( int *width, int *height ) const
if (m_frameStatusBar && m_frameStatusBar->IsShown())
(*height) -= wxSTATUS_HEIGHT;
#endif // wxUSE_STATUSBAR
}
#if wxUSE_TOOLBAR
// tool bar
@@ -259,6 +243,7 @@ void wxFrame::DoGetClientSize( int *width, int *height ) const
{
if (m_toolBarDetached)
{
if (height != NULL)
*height -= wxPLACE_HOLDER;
}
else
@@ -267,19 +252,23 @@ void wxFrame::DoGetClientSize( int *width, int *height ) const
m_frameToolBar->GetSize( &x, &y );
if ( m_frameToolBar->GetWindowStyle() & wxTB_VERTICAL )
{
if (width != NULL)
*width -= x;
}
else
{
if (height != NULL)
*height -= y;
}
}
}
#endif // wxUSE_TOOLBAR
if (*height < 0)
if (width != NULL && *width < 0)
*width = 0;
if (height != NULL && *height < 0)
*height = 0;
}
}
void wxFrame::DoSetClientSize( int width, int height )
{