cleanup - fixed warnings, reformatting

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@38088 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
David Surovell
2006-03-15 06:22:36 +00:00
parent 74af7bcf4f
commit c18353e561
2 changed files with 175 additions and 161 deletions

View File

@@ -1,5 +1,5 @@
/////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////
// Name: checklst.cpp // Name: src/mac/carbon/checklst.cpp
// Purpose: implementation of wxCheckListBox class // Purpose: implementation of wxCheckListBox class
// Author: Stefan Csomor // Author: Stefan Csomor
// Modified by: // Modified by:
@@ -8,10 +8,9 @@
// Copyright: (c) Stefan Csomor // Copyright: (c) Stefan Csomor
// Licence: wxWindows licence // Licence: wxWindows licence
/////////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////////
//
// new DataBrowser-based version
// ============================================================================
// headers & declarations
// ============================================================================
#include "wx/wxprec.h" #include "wx/wxprec.h"
@@ -21,143 +20,149 @@
#include "wx/arrstr.h" #include "wx/arrstr.h"
#include "wx/mac/uma.h" #include "wx/mac/uma.h"
#ifndef __DARWIN__ #ifndef __DARWIN__
#include <Appearance.h> #include <Appearance.h>
#endif #endif
// ============================================================================
// implementation of wxCheckListBox
// ============================================================================
IMPLEMENT_DYNAMIC_CLASS(wxCheckListBox, wxListBox) IMPLEMENT_DYNAMIC_CLASS(wxCheckListBox, wxListBox)
BEGIN_EVENT_TABLE(wxCheckListBox, wxListBox) BEGIN_EVENT_TABLE(wxCheckListBox, wxListBox)
END_EVENT_TABLE() END_EVENT_TABLE()
const short kTextColumnId = 1024 ; const short kTextColumnId = 1024;
const short kCheckboxColumnId = 1025 ; const short kCheckboxColumnId = 1025;
// new databrowser based version
// Listbox item
void wxCheckListBox::Init() void wxCheckListBox::Init()
{ {
} }
bool wxCheckListBox::Create(wxWindow *parent, bool wxCheckListBox::Create(
wxWindowID id, wxWindow *parent,
const wxPoint &pos, wxWindowID id,
const wxSize &size, const wxPoint &pos,
const wxArrayString& choices, const wxSize &size,
long style, const wxArrayString& choices,
const wxValidator& validator, long style,
const wxString &name) const wxValidator& validator,
const wxString &name )
{ {
wxCArrayString chs(choices); wxCArrayString chs( choices );
return Create(parent, id, pos, size, chs.GetCount(), chs.GetStrings(), return Create( parent, id, pos, size, chs.GetCount(), chs.GetStrings(), style, validator, name );
style, validator, name);
} }
#if TARGET_API_MAC_OSX #if TARGET_API_MAC_OSX
static pascal void DataBrowserItemNotificationProc(ControlRef browser, DataBrowserItemID itemID, static pascal void DataBrowserItemNotificationProc(
DataBrowserItemNotification message, DataBrowserItemDataRef itemData) ControlRef browser,
DataBrowserItemID itemID,
DataBrowserItemNotification message,
DataBrowserItemDataRef itemData )
#else #else
static pascal void DataBrowserItemNotificationProc(ControlRef browser, DataBrowserItemID itemID, static pascal void DataBrowserItemNotificationProc(
DataBrowserItemNotification message) ControlRef browser,
DataBrowserItemID itemID,
DataBrowserItemNotification message )
#endif #endif
{ {
long ref = GetControlReference( browser ) ; long ref = GetControlReference( browser );
if ( ref ) if (ref != 0)
{ {
wxCheckListBox* list = wxDynamicCast( (wxObject*) ref , wxCheckListBox ) ; wxCheckListBox* list = wxDynamicCast( (wxObject*)ref, wxCheckListBox );
int i = itemID - 1 ; int i = itemID - 1;
if (i >= 0 && i < list->GetCount() ) if ((i >= 0) && (i < (int)list->GetCount()))
{ {
bool trigger = false ; bool trigger = false;
wxCommandEvent event( wxCommandEvent event( wxEVT_COMMAND_LISTBOX_SELECTED, list->GetId() );
wxEVT_COMMAND_LISTBOX_SELECTED, list->GetId() ); switch ( message )
switch( message )
{ {
case kDataBrowserItemDeselected : case kDataBrowserItemDeselected:
if ( list->HasMultipleSelection() ) if ( list->HasMultipleSelection() )
trigger = true ; trigger = true;
break ; break;
case kDataBrowserItemSelected :
trigger = true ; case kDataBrowserItemSelected:
break ; trigger = true;
case kDataBrowserItemDoubleClicked : break;
event.SetEventType(wxEVT_COMMAND_LISTBOX_DOUBLECLICKED) ;
trigger = true ; case kDataBrowserItemDoubleClicked:
break ; event.SetEventType( wxEVT_COMMAND_LISTBOX_DOUBLECLICKED );
default : trigger = true;
break ; break;
default:
break;
} }
if ( trigger ) if ( trigger )
{ {
event.SetEventObject( list ); event.SetEventObject( list );
if ( list->HasClientObjectData() ) if ( list->HasClientObjectData() )
event.SetClientObject( list->GetClientObject(i) ); event.SetClientObject( list->GetClientObject( i ) );
else if ( list->HasClientUntypedData() ) else if ( list->HasClientUntypedData() )
event.SetClientData( list->GetClientData(i) ); event.SetClientData( list->GetClientData( i ) );
event.SetString( list->GetString(i) ); event.SetString( list->GetString( i ) );
event.SetInt(i) ; event.SetInt( i );
event.SetExtraLong( list->HasMultipleSelection() ? message == kDataBrowserItemSelected : TRUE ); event.SetExtraLong( list->HasMultipleSelection() ? message == kDataBrowserItemSelected : true );
wxPostEvent( list->GetEventHandler() , event ) ; wxPostEvent( list->GetEventHandler(), event );
// direct notification is not always having the listbox GetSelection() having in synch with event
// list->GetEventHandler()->ProcessEvent(event) ; // direct notification is not always having the listbox GetSelection() having in sync with event
// list->GetEventHandler()->ProcessEvent( event );
} }
} }
} }
} }
static pascal OSStatus ListBoxGetSetItemData(
static pascal OSStatus ListBoxGetSetItemData(ControlRef browser, ControlRef browser,
DataBrowserItemID itemID, DataBrowserPropertyID property, DataBrowserItemID itemID,
DataBrowserItemDataRef itemData, Boolean changeValue) DataBrowserPropertyID property,
DataBrowserItemDataRef itemData,
Boolean changeValue )
{ {
OSStatus err = errDataBrowserPropertyNotSupported; OSStatus err = errDataBrowserPropertyNotSupported;
if ( ! changeValue ) if ( !changeValue )
{ {
switch (property) switch (property)
{ {
case kTextColumnId: case kTextColumnId:
{ {
long ref = GetControlReference( browser ) ; long ref = GetControlReference( browser );
if ( ref ) if (ref != 0)
{ {
wxCheckListBox* list = wxDynamicCast( (wxObject*) ref , wxCheckListBox ) ; wxCheckListBox* list = wxDynamicCast( (wxObject*) ref, wxCheckListBox );
int i = itemID - 1 ; int i = itemID - 1;
if (i >= 0 && i < list->GetCount() ) if ((i >= 0) && (i < (int)list->GetCount()))
{ {
wxMacCFStringHolder cf( list->GetString(i) , list->GetFont().GetEncoding() ) ; wxMacCFStringHolder cf( list->GetString( i ), list->GetFont().GetEncoding() );
verify_noerr( ::SetDataBrowserItemDataText( itemData , cf ) ) ; verify_noerr( ::SetDataBrowserItemDataText( itemData, cf ) );
err = noErr ; err = noErr;
} }
} }
} }
break; break;
case kCheckboxColumnId :
case kCheckboxColumnId:
{ {
long ref = GetControlReference( browser ) ; long ref = GetControlReference( browser );
if ( ref ) if (ref != 0)
{ {
wxCheckListBox* list = wxDynamicCast( (wxObject*) ref , wxCheckListBox ) ; wxCheckListBox* list = wxDynamicCast( (wxObject*)ref, wxCheckListBox );
int i = itemID - 1 ; int i = itemID - 1;
if (i >= 0 && i < list->GetCount() ) if ((i >= 0) && (i < (int)list->GetCount()))
{ {
verify_noerr( ::SetDataBrowserItemDataButtonValue( itemData , list->IsChecked( i ) ? kThemeButtonOn : kThemeButtonOff ) ) ; verify_noerr( ::SetDataBrowserItemDataButtonValue( itemData, list->IsChecked( i ) ? kThemeButtonOn : kThemeButtonOff ) );
err = noErr ; err = noErr;
} }
} }
} }
break ; break;
case kDataBrowserItemIsEditableProperty: case kDataBrowserItemIsEditableProperty:
{ {
err = ::SetDataBrowserItemDataBooleanValue(itemData, true); err = ::SetDataBrowserItemDataBooleanValue( itemData, true );
} }
break; break;
@@ -167,69 +172,75 @@ static pascal OSStatus ListBoxGetSetItemData(ControlRef browser,
} }
else else
{ {
switch( property ) switch ( property )
{ {
case kCheckboxColumnId : case kCheckboxColumnId:
{ {
long ref = GetControlReference( browser ) ; long ref = GetControlReference( browser );
if ( ref ) if (ref != 0)
{ {
wxCheckListBox* list = wxDynamicCast( (wxObject*) ref , wxCheckListBox ) ; wxCheckListBox* list = wxDynamicCast( (wxObject*) ref, wxCheckListBox );
int i = itemID - 1 ; int i = itemID - 1;
if (i >= 0 && i < list->GetCount() ) if ((i >= 0) && (i < (int)list->GetCount()))
{ {
// we have to change this behind the back, since Check() would be triggering another update round // we have to change this behind the back, since Check() would be triggering another update round
bool newVal = !list->IsChecked( i ) ; bool newVal = !list->IsChecked( i );
verify_noerr( ::SetDataBrowserItemDataButtonValue( itemData , newVal ? kThemeButtonOn : kThemeButtonOff ) ) ; verify_noerr( ::SetDataBrowserItemDataButtonValue( itemData, newVal ? kThemeButtonOn : kThemeButtonOff ) );
err = noErr ; err = noErr;
list->m_checks[ i ] = newVal ; list->m_checks[i] = newVal;
wxCommandEvent event(wxEVT_COMMAND_CHECKLISTBOX_TOGGLED, list->GetId()); wxCommandEvent event(wxEVT_COMMAND_CHECKLISTBOX_TOGGLED, list->GetId());
event.SetInt(i); event.SetInt( i );
event.SetEventObject(list); event.SetEventObject( list );
list->GetEventHandler()->ProcessEvent(event); list->GetEventHandler()->ProcessEvent( event );
} }
} }
} }
break ; break;
default : default:
break ; break;
} }
} }
return err; return err;
} }
bool wxCheckListBox::Create(wxWindow *parent, wxWindowID id,
const wxPoint& pos, bool wxCheckListBox::Create(
const wxSize& size, wxWindow *parent,
int n, const wxString choices[], wxWindowID id,
long style, const wxPoint& pos,
const wxValidator& validator, const wxSize& size,
const wxString& name) int n,
const wxString choices[],
long style,
const wxValidator& validator,
const wxString& name )
{ {
m_macIsUserPane = false ; m_macIsUserPane = false;
wxASSERT_MSG( !(style & wxLB_MULTIPLE) || !(style & wxLB_EXTENDED), wxASSERT_MSG( !(style & wxLB_MULTIPLE) || !(style & wxLB_EXTENDED),
_T("only one of listbox selection modes can be specified") ); wxT("only one of listbox selection modes can be specified") );
if ( !wxListBoxBase::Create(parent, id, pos, size, style & ~(wxHSCROLL|wxVSCROLL), validator, name) ) if ( !wxListBoxBase::Create( parent, id, pos, size, style & ~(wxHSCROLL | wxVSCROLL), validator, name ) )
return false; return false;
m_noItems = 0 ; // this will be increased by our append command // this will be increased by our Append command
m_noItems = 0;
m_selected = 0; m_selected = 0;
Rect bounds = wxMacGetBoundsForControl( this , pos , size ) ; Rect bounds = wxMacGetBoundsForControl( this, pos, size );
m_peer = new wxMacControl(this) ; m_peer = new wxMacControl( this );
verify_noerr( ::CreateDataBrowserControl( MAC_WXHWND(parent->MacGetTopLevelWindowRef()), &bounds, kDataBrowserListView , m_peer->GetControlRefAddr() ) ); OSStatus err = ::CreateDataBrowserControl(
MAC_WXHWND(parent->MacGetTopLevelWindowRef()),
&bounds, kDataBrowserListView, m_peer->GetControlRefAddr() );
verify_noerr( err );
DataBrowserSelectionFlags options = kDataBrowserDragSelect;
DataBrowserSelectionFlags options = kDataBrowserDragSelect ;
if ( style & wxLB_MULTIPLE ) if ( style & wxLB_MULTIPLE )
{ {
options += kDataBrowserAlwaysExtendSelection + kDataBrowserCmdTogglesSelection ; options |= kDataBrowserAlwaysExtendSelection | kDataBrowserCmdTogglesSelection;
} }
else if ( style & wxLB_EXTENDED ) else if ( style & wxLB_EXTENDED )
{ {
@@ -237,11 +248,13 @@ bool wxCheckListBox::Create(wxWindow *parent, wxWindowID id,
} }
else else
{ {
options += kDataBrowserSelectOnlyOne ; options |= kDataBrowserSelectOnlyOne;
} }
verify_noerr(m_peer->SetSelectionFlags( options ) );
DataBrowserListViewColumnDesc columnDesc ; err = m_peer->SetSelectionFlags( options );
verify_noerr( err );
DataBrowserListViewColumnDesc columnDesc;
columnDesc.headerBtnDesc.titleOffset = 0; columnDesc.headerBtnDesc.titleOffset = 0;
columnDesc.headerBtnDesc.version = kDataBrowserListViewLatestHeaderDesc; columnDesc.headerBtnDesc.version = kDataBrowserListViewLatestHeaderDesc;
@@ -252,18 +265,21 @@ bool wxCheckListBox::Create(wxWindow *parent, wxWindowID id,
columnDesc.headerBtnDesc.btnFontStyle.just = teFlushDefault; columnDesc.headerBtnDesc.btnFontStyle.just = teFlushDefault;
columnDesc.headerBtnDesc.btnFontStyle.font = kControlFontViewSystemFont; columnDesc.headerBtnDesc.btnFontStyle.font = kControlFontViewSystemFont;
columnDesc.headerBtnDesc.btnFontStyle.style = normal; columnDesc.headerBtnDesc.btnFontStyle.style = normal;
columnDesc.headerBtnDesc.titleString = NULL ; // CFSTR( "" ); columnDesc.headerBtnDesc.titleString = NULL; // CFSTR( "" );
// check column // check column
columnDesc.headerBtnDesc.minimumWidth = 30 ; columnDesc.headerBtnDesc.minimumWidth = 30;
columnDesc.headerBtnDesc.maximumWidth = 30; columnDesc.headerBtnDesc.maximumWidth = 30;
columnDesc.propertyDesc.propertyID = kCheckboxColumnId; columnDesc.propertyDesc.propertyID = kCheckboxColumnId;
columnDesc.propertyDesc.propertyType = kDataBrowserCheckboxType; columnDesc.propertyDesc.propertyType = kDataBrowserCheckboxType;
columnDesc.propertyDesc.propertyFlags = kDataBrowserPropertyIsMutable | kDataBrowserTableViewSelectionColumn | columnDesc.propertyDesc.propertyFlags =
kDataBrowserDefaultPropertyFlags; kDataBrowserPropertyIsMutable
verify_noerr( m_peer->AddListViewColumn( &columnDesc, kDataBrowserListViewAppendColumn) ) ; | kDataBrowserTableViewSelectionColumn
| kDataBrowserDefaultPropertyFlags;
err = m_peer->AddListViewColumn( &columnDesc, kDataBrowserListViewAppendColumn );
verify_noerr( err );
// text column // text column
@@ -278,40 +294,40 @@ bool wxCheckListBox::Create(wxWindow *parent, wxWindowID id,
#endif #endif
; ;
verify_noerr( m_peer->AddListViewColumn( &columnDesc, kDataBrowserListViewAppendColumn ) );
verify_noerr( m_peer->AddListViewColumn( &columnDesc, kDataBrowserListViewAppendColumn) ) ; verify_noerr( m_peer->AutoSizeListViewColumns() );
verify_noerr( m_peer->SetHasScrollBars( false, true ) );
verify_noerr( m_peer->SetTableViewHiliteStyle( kDataBrowserTableViewFillHilite ) );
verify_noerr( m_peer->SetListViewHeaderBtnHeight( 0 ) );
verify_noerr( m_peer->AutoSizeListViewColumns() ) ; DataBrowserCallbacks callbacks;
verify_noerr( m_peer->SetHasScrollBars( false , true ) ) ;
verify_noerr( m_peer->SetTableViewHiliteStyle( kDataBrowserTableViewFillHilite ) ) ;
verify_noerr( m_peer->SetListViewHeaderBtnHeight(0 ) ) ;
DataBrowserCallbacks callbacks ;
callbacks.version = kDataBrowserLatestCallbacks; callbacks.version = kDataBrowserLatestCallbacks;
InitDataBrowserCallbacks(&callbacks); InitDataBrowserCallbacks( &callbacks );
callbacks.u.v1.itemDataCallback = NewDataBrowserItemDataUPP(ListBoxGetSetItemData); callbacks.u.v1.itemDataCallback = NewDataBrowserItemDataUPP( &ListBoxGetSetItemData );
callbacks.u.v1.itemNotificationCallback = callbacks.u.v1.itemNotificationCallback =
#if TARGET_API_MAC_OSX #if TARGET_API_MAC_OSX
(DataBrowserItemNotificationUPP) NewDataBrowserItemNotificationWithItemUPP(DataBrowserItemNotificationProc) ; (DataBrowserItemNotificationUPP) NewDataBrowserItemNotificationWithItemUPP( &DataBrowserItemNotificationProc );
#else #else
NewDataBrowserItemNotificationUPP(DataBrowserItemNotificationProc) ; NewDataBrowserItemNotificationUPP( &DataBrowserItemNotificationProc );
#endif #endif
m_peer->SetCallbacks( &callbacks); m_peer->SetCallbacks( &callbacks );
#if 0 #if 0
// shouldn't be necessary anymore under 10.2 // shouldn't be necessary anymore under 10.2
m_peer->SetData( kControlNoPart, kControlDataBrowserIncludesFrameAndFocusTag, (Boolean) false ) ; m_peer->SetData( kControlNoPart, kControlDataBrowserIncludesFrameAndFocusTag, (Boolean)false );
m_peer->SetNeedsFocusRect( true ) ; m_peer->SetNeedsFocusRect( true );
#endif #endif
MacPostControlCreate(pos,size) ; MacPostControlCreate( pos, size );
for ( int i = 0 ; i < n ; i++ ) for ( int i = 0; i < n; i++ )
{ {
Append( choices[i] ) ; Append( choices[i] );
} }
SetBestSize(size); // Needed because it is a wxControlWithItems // Needed because it is a wxControlWithItems
SetBestSize( size );
return true; return true;
} }
@@ -323,7 +339,7 @@ bool wxCheckListBox::Create(wxWindow *parent, wxWindowID id,
bool wxCheckListBox::IsChecked(size_t item) const bool wxCheckListBox::IsChecked(size_t item) const
{ {
wxCHECK_MSG( item < m_checks.GetCount(), false, wxCHECK_MSG( item < m_checks.GetCount(), false,
_T("invalid index in wxCheckListBox::IsChecked") ); wxT("invalid index in wxCheckListBox::IsChecked") );
return m_checks[item] != 0; return m_checks[item] != 0;
} }
@@ -331,14 +347,17 @@ bool wxCheckListBox::IsChecked(size_t item) const
void wxCheckListBox::Check(size_t item, bool check) void wxCheckListBox::Check(size_t item, bool check)
{ {
wxCHECK_RET( item < m_checks.GetCount(), wxCHECK_RET( item < m_checks.GetCount(),
_T("invalid index in wxCheckListBox::Check") ); wxT("invalid index in wxCheckListBox::Check") );
bool isChecked = m_checks[item] != 0; bool isChecked = m_checks[item] != 0;
if ( check != isChecked ) if ( check != isChecked )
{ {
m_checks[item] = check; m_checks[item] = check;
UInt32 id = item + 1 ; UInt32 id = item + 1;
verify_noerr( m_peer->UpdateItems(kDataBrowserNoItem , 1 , &id , kDataBrowserItemNoProperty , kDataBrowserItemNoProperty ) ) ; OSStatus err = m_peer->UpdateItems(
kDataBrowserNoItem, 1, &id,
kDataBrowserItemNoProperty, kDataBrowserItemNoProperty );
verify_noerr( err );
} }
} }
@@ -348,43 +367,42 @@ void wxCheckListBox::Check(size_t item, bool check)
void wxCheckListBox::Delete(int n) void wxCheckListBox::Delete(int n)
{ {
wxCHECK_RET( n < GetCount(), _T("invalid index in wxCheckListBox::Delete") ); wxCHECK_RET( (size_t)n < GetCount(), wxT("invalid index in wxCheckListBox::Delete") );
wxListBox::Delete(n); wxListBox::Delete( n );
m_checks.RemoveAt( n );
m_checks.RemoveAt(n);
} }
int wxCheckListBox::DoAppend(const wxString& item) int wxCheckListBox::DoAppend(const wxString& item)
{ {
int pos = wxListBox::DoAppend(item); int pos = wxListBox::DoAppend( item );
// the item is initially unchecked // the item is initially unchecked
m_checks.Insert(false, pos); m_checks.Insert( false, pos );
return pos; return pos;
} }
void wxCheckListBox::DoInsertItems(const wxArrayString& items, int pos) void wxCheckListBox::DoInsertItems(const wxArrayString& items, int pos)
{ {
wxListBox::DoInsertItems(items, pos); wxListBox::DoInsertItems( items, pos );
size_t count = items.GetCount(); size_t count = items.GetCount();
for ( size_t n = 0; n < count; n++ ) for ( size_t n = 0; n < count; n++ )
{ {
m_checks.Insert(false, pos + n); m_checks.Insert( false, pos + n );
} }
} }
void wxCheckListBox::DoSetItems(const wxArrayString& items, void **clientData) void wxCheckListBox::DoSetItems(const wxArrayString& items, void **clientData)
{ {
// call it first as it does DoClear() // call it first as it does DoClear()
wxListBox::DoSetItems(items, clientData); wxListBox::DoSetItems( items, clientData );
size_t count = items.GetCount(); size_t count = items.GetCount();
for ( size_t n = 0; n < count; n++ ) for ( size_t n = 0; n < count; n++ )
{ {
m_checks.Add(false); m_checks.Add( false );
} }
} }

View File

@@ -9,10 +9,6 @@
// Licence: wxWindows licence // Licence: wxWindows licence
///////////////////////////////////////////////////////////////////////////// /////////////////////////////////////////////////////////////////////////////
//-------------------------------------------------------------------------------------
// headers
//-------------------------------------------------------------------------------------
#include "wx/wxprec.h" #include "wx/wxprec.h"
#if wxUSE_RADIOBOX #if wxUSE_RADIOBOX
@@ -107,7 +103,7 @@ bool wxRadioBox::Create( wxWindow *parent,
SetMajorDim( majorDim == 0 ? n : majorDim, style ); SetMajorDim( majorDim == 0 ? n : majorDim, style );
m_label = label ; m_label = label;
Rect bounds = wxMacGetBoundsForControl( this, pos, size ); Rect bounds = wxMacGetBoundsForControl( this, pos, size );
if ( bounds.right <= bounds.left ) if ( bounds.right <= bounds.left )
@@ -433,7 +429,7 @@ void wxRadioBox::DoSetSize(int x, int y, int width, int height, int sizeFlags)
y_offset = y_start; y_offset = y_start;
current = m_radioButtonCycle; current = m_radioButtonCycle;
for ( i = 0 ; i < m_noItems; i++) for (i = 0 ; i < (int)m_noItems; i++)
{ {
// not to do for the zero button! // not to do for the zero button!
if ((i > 0) && ((i % GetMajorDim()) == 0)) if ((i > 0) && ((i % GetMajorDim()) == 0))