Add default value for MakeConfigFileName() 2nd argument

Make it possible to call wxStandardPaths::MakeConfigFileName() without
explicitly specifying the convention to use, to make it conform to the
documentation (previously this only worked when calling the
wxStandardPathsBase version of the method).

Closes #18106.
This commit is contained in:
Vadim Zeitlin
2018-03-17 17:17:05 +01:00
parent aee46e075f
commit b97ea90f4f
4 changed files with 12 additions and 6 deletions

View File

@@ -30,7 +30,8 @@ public:
virtual wxString GetPluginsDir() const wxOVERRIDE; virtual wxString GetPluginsDir() const wxOVERRIDE;
virtual wxString GetUserDir(Dir userDir) const wxOVERRIDE; virtual wxString GetUserDir(Dir userDir) const wxOVERRIDE;
virtual wxString MakeConfigFileName(const wxString& basename, virtual wxString MakeConfigFileName(const wxString& basename,
ConfigFileConv conv) const wxOVERRIDE; ConfigFileConv conv = ConfigFileConv_Ext
) const wxOVERRIDE;
// MSW-specific methods // MSW-specific methods

View File

@@ -33,7 +33,8 @@ public:
ResourceCat category = ResourceCat_None) const wxOVERRIDE; ResourceCat category = ResourceCat_None) const wxOVERRIDE;
virtual wxString GetUserDir(Dir userDir) const wxOVERRIDE; virtual wxString GetUserDir(Dir userDir) const wxOVERRIDE;
virtual wxString MakeConfigFileName(const wxString& basename, virtual wxString MakeConfigFileName(const wxString& basename,
ConfigFileConv conv) const wxOVERRIDE; ConfigFileConv conv = ConfigFileConv_Ext
) const wxOVERRIDE;
protected: protected:
// Ctor is protected, use wxStandardPaths::Get() instead of instantiating // Ctor is protected, use wxStandardPaths::Get() instead of instantiating

View File

@@ -252,9 +252,12 @@ public:
virtual wxString GetUserDataDir() const { return m_prefix; } virtual wxString GetUserDataDir() const { return m_prefix; }
virtual wxString GetPluginsDir() const { return m_prefix; } virtual wxString GetPluginsDir() const { return m_prefix; }
virtual wxString GetUserDir(Dir WXUNUSED(userDir)) const { return m_prefix; } virtual wxString GetUserDir(Dir WXUNUSED(userDir)) const { return m_prefix; }
virtual wxString MakeConfigFileName(const wxString& basename, virtual wxString
ConfigFileConv WXUNUSED(conv)) const MakeConfigFileName(const wxString& basename,
{ return m_prefix + wxS("/") + basename; } ConfigFileConv WXUNUSED(conv) = ConfigFileConv_Ext) const
{
return m_prefix + wxS("/") + basename;
}
protected: protected:
// Ctor is protected because wxStandardPaths::Get() should always be used // Ctor is protected because wxStandardPaths::Get() should always be used

View File

@@ -50,7 +50,8 @@ public:
virtual wxString GetUserDir(Dir userDir) const wxOVERRIDE; virtual wxString GetUserDir(Dir userDir) const wxOVERRIDE;
#endif #endif
virtual wxString MakeConfigFileName(const wxString& basename, virtual wxString MakeConfigFileName(const wxString& basename,
ConfigFileConv conv) const wxOVERRIDE; ConfigFileConv conv = ConfigFileConv_Ext
) const wxOVERRIDE;
protected: protected:
// Ctor is protected, use wxStandardPaths::Get() instead of instantiating // Ctor is protected, use wxStandardPaths::Get() instead of instantiating