From b96cc406f49517f25d2c3a823fdbe6567775a48f Mon Sep 17 00:00:00 2001 From: Graham Dawes Date: Thu, 7 Feb 2019 14:24:52 +0000 Subject: [PATCH] Don't add item to tree until its fully constructed (prevents itemChanged signal from firing). --- src/qt/treectrl.cpp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/qt/treectrl.cpp b/src/qt/treectrl.cpp index 717a2cfdb2..fbf261a7a9 100644 --- a/src/qt/treectrl.cpp +++ b/src/qt/treectrl.cpp @@ -1075,15 +1075,6 @@ wxTreeItemId wxTreeCtrl::DoInsertItem(const wxTreeItemId& parent, newItem->setData(0, Qt::UserRole, QVariant::fromValue(treeItemData)); - if (pos == static_cast(-1)) - { - qTreeItem->addChild(newItem); - } - else - { - qTreeItem->insertChild(pos, newItem); - } - m_qtTreeWidget->SetItemImage(newItem, image, wxTreeItemIcon_Normal); m_qtTreeWidget->SetItemImage(newItem, selImage, wxTreeItemIcon_Selected); @@ -1094,6 +1085,15 @@ wxTreeItemId wxTreeCtrl::DoInsertItem(const wxTreeItemId& parent, if (data != NULL) data->SetId(wxItem); + if (pos == static_cast(-1)) + { + qTreeItem->addChild(newItem); + } + else + { + qTreeItem->insertChild(pos, newItem); + } + return wxItem; }