do *NOT* make the window of the size of its parent initially, fixes missing EVT_SIZE problem

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@11947 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

src/msw/window.cpp

@@ -2692,29 +2692,32 @@ bool wxWindowMSW::MSWGetCreateWindowCoords(const wxPoint& pos,
         nonDefault = TRUE;
     }
 
-    if ( size.x == -1 || size.y == -1 )
+    /*
-    {
+      NB: there used to be some code here which set the initial size of the
-        // Find parent's size, if it exists, to set up a possible default panel
+          window to the client size of the parent if no explicit size was
-        // size the size of the parent window
+          specified. This was wrong because wxWindows programs often assume
-        wxWindow *parent = GetParent();
+          that they get a WM_SIZE (EVT_SIZE) upon creation, however this broke
-        if ( parent )
+          it. To see why, you should understand that Windows sends WM_SIZE from
-        {
+          inside ::CreateWindow() anyhow. However, ::CreateWindow() is called
-            RECT rectParent;
+          from some base class ctor and so this WM_SIZE is not processed in the
-            ::GetClientRect(GetHwndOf(parent), &rectParent);
+          real class' OnSize() (because it's not fully constructed yet and the
-
+          event goes to some base class OnSize() instead). So the WM_SIZE we
-            w = size.x == -1 ? rectParent.right - rectParent.left : size.x;
+          rely on is the one sent when the parent frame resizes its children
-            h = size.y == -1 ? rectParent.bottom - rectParent.top : size.y;
+          but here is the problem: if the child already has just the right
-        }
+          size, nothing will happen as both wxWindows and Windows check for
-        else
+          this and ignore any attempts to change the window size to the size it
+          already has - so no WM_SIZE would be sent.
+     */
+    if ( size.x == -1 )
     {
+        // as abobe, h is not used at all in this case anyhow
         w =
         h = CW_USEDEFAULT;
     }
-    }
     else
     {
         w = size.x;
-        h = size.y;
+        h = size.y == -1 ? CW_USEDEFAULT : size.y;
 
         nonDefault = TRUE;
     }