Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update comments to remove mentions of 4KiB for /sys files

Browse Source 
The actual size is the page size, so update the comments to match the
changes to the code in the previous commit.
This commit is contained in:
Vadim Zeitlin
2020-04-07 13:38:34 +02:00
parent b2b1b21bf2
commit b714a3614b
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/file/filetest.cpp
View File

@@ -156,14 +156,16 @@ TEST_CASE("wxFile::Special", "[file][linux][special-file]")
CHECK( fileProc.ReadAll(&s) ); CHECK( fileProc.ReadAll(&s) );
CHECK( !s.empty() ); CHECK( !s.empty() );
// All files in /sys seem to have size of 4KiB currently, even if they // All files in /sys have the size of one kernel page, even if they don't
// don't have that much data in them. // have that much data in them.
const long pageSize = sysconf(_SC_PAGESIZE);
wxFile fileSys("/sys/power/state"); wxFile fileSys("/sys/power/state");
CHECK( fileSys.Length() == sysconf(_SC_PAGESIZE) ); CHECK( fileSys.Length() == pageSize );
CHECK( fileSys.IsOpened() ); CHECK( fileSys.IsOpened() );
CHECK( fileSys.ReadAll(&s) ); CHECK( fileSys.ReadAll(&s) );
CHECK( !s.empty() ); CHECK( !s.empty() );
CHECK( s.length() < 4096 ); CHECK( s.length() < pageSize );
} }
#endif // __LINUX__ #endif // __LINUX__

3
tests/filename/filenametest.cpp
View File

@@ -1059,7 +1059,8 @@ TEST_CASE("wxFileName::GetSizeSpecial", "[filename][linux][special-file]")
INFO( "size of /proc/kcore=" << size ); INFO( "size of /proc/kcore=" << size );
CHECK( size > 0 ); CHECK( size > 0 );
// All files in /sys seem to have size of 4KiB currently. // All files in /sys are one page in size, irrespectively of the size of
// their actual contents.
CHECK( wxFileName::GetSize("/sys/power/state") == sysconf(_SC_PAGESIZE) ); CHECK( wxFileName::GetSize("/sys/power/state") == sysconf(_SC_PAGESIZE) );
} }