Replaced one call to isalpha with wxIsalnum in wxURL::ConvertToValidURI because:

a) numeric characters are also valid in an URI
b) wxIsXXX should be used for wxChar instead of ANSI-C isXXX, so that the
   code will also work in Unicode builds


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/branches/WX_2_2_BRANCH@6969 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Guillermo Rodriguez Garcia
2000-03-28 08:59:12 +00:00
parent d6f6f90a65
commit b60473e401

View File

@@ -77,35 +77,40 @@ bool wxURL::ParseURL()
{ {
wxString last_url = m_url; wxString last_url = m_url;
// If the URL was already parsed (so m_protocol != NULL), we pass this section. // If the URL was already parsed (m_protocol != NULL), pass this section.
if (!m_protocol) { if (!m_protocol)
{
// Clean up // Clean up
CleanData(); CleanData();
// Extract protocol name // Extract protocol name
if (!PrepProto(last_url)) { if (!PrepProto(last_url))
{
m_error = wxURL_SNTXERR; m_error = wxURL_SNTXERR;
return FALSE; return FALSE;
} }
// Find and create the protocol object // Find and create the protocol object
if (!FetchProtocol()) { if (!FetchProtocol())
{
m_error = wxURL_NOPROTO; m_error = wxURL_NOPROTO;
return FALSE; return FALSE;
} }
// Do we need a host name ? // Do we need a host name ?
if (m_protoinfo->m_needhost) { if (m_protoinfo->m_needhost)
{
// Extract it // Extract it
if (!PrepHost(last_url)) { if (!PrepHost(last_url))
{
m_error = wxURL_SNTXERR; m_error = wxURL_SNTXERR;
return FALSE; return FALSE;
} }
} }
// Extract full path // Extract full path
if (!PrepPath(last_url)) { if (!PrepPath(last_url))
{
m_error = wxURL_NOPATH; m_error = wxURL_NOPATH;
return FALSE; return FALSE;
} }
@@ -113,7 +118,8 @@ bool wxURL::ParseURL()
// URL parse finished. // URL parse finished.
#if wxUSE_SOCKETS #if wxUSE_SOCKETS
if (m_useProxy) { if (m_useProxy)
{
// We destroy the newly created protocol. // We destroy the newly created protocol.
CleanData(); CleanData();
@@ -192,7 +198,8 @@ bool wxURL::PrepHost(wxString& url)
// Retrieve service number // Retrieve service number
pos2 = temp_url.Find(wxT(':'), TRUE); pos2 = temp_url.Find(wxT(':'), TRUE);
if (pos2 != -1 && pos2 < pos) { if (pos2 != -1 && pos2 < pos)
{
m_servname = temp_url(pos2+1, pos); m_servname = temp_url(pos2+1, pos);
if (!m_servname.IsNumber()) if (!m_servname.IsNumber())
return FALSE; return FALSE;
@@ -235,8 +242,10 @@ bool wxURL::FetchProtocol()
{ {
wxProtoInfo *info = ms_protocols; wxProtoInfo *info = ms_protocols;
while (info) { while (info)
if (m_protoname == info->m_protoname) { {
if (m_protoname == info->m_protoname)
{
if (m_servname.IsNull()) if (m_servname.IsNull())
m_servname = info->m_servname; m_servname = info->m_servname;
@@ -257,13 +266,15 @@ wxInputStream *wxURL::GetInputStream()
{ {
wxInputStream *the_i_stream = NULL; wxInputStream *the_i_stream = NULL;
if (!m_protocol) { if (!m_protocol)
{
m_error = wxURL_NOPROTO; m_error = wxURL_NOPROTO;
return NULL; return NULL;
} }
m_error = wxURL_NOERR; m_error = wxURL_NOERR;
if (m_user != wxT("")) { if (m_user != wxT(""))
{
m_protocol->SetUser(m_user); m_protocol->SetUser(m_user);
m_protocol->SetPassword(m_password); m_protocol->SetPassword(m_password);
} }
@@ -272,8 +283,10 @@ wxInputStream *wxURL::GetInputStream()
wxIPV4address addr; wxIPV4address addr;
// m_protoinfo is NULL when we use a proxy // m_protoinfo is NULL when we use a proxy
if (!m_useProxy && m_protoinfo->m_needhost) { if (!m_useProxy && m_protoinfo->m_needhost)
if (!addr.Hostname(m_hostname)) { {
if (!addr.Hostname(m_hostname))
{
m_error = wxURL_NOHOST; m_error = wxURL_NOHOST;
return NULL; return NULL;
} }
@@ -294,7 +307,8 @@ wxInputStream *wxURL::GetInputStream()
else else
the_i_stream = m_protocol->GetInputStream(m_path); the_i_stream = m_protocol->GetInputStream(m_path);
if (!the_i_stream) { if (!the_i_stream)
{
m_error = wxURL_PROTOERR; m_error = wxURL_PROTOERR;
return NULL; return NULL;
} }
@@ -390,17 +404,25 @@ wxString wxURL::ConvertToValidURI(const wxString& uri)
wxString hexa_code; wxString hexa_code;
size_t i; size_t i;
for (i=0;i<uri.Len();i++) { for (i=0;i<uri.Len();i++)
{
wxChar c = uri.GetChar(i); wxChar c = uri.GetChar(i);
if (c == wxT(' ')) if (c == wxT(' '))
{
out_str += wxT('+'); out_str += wxT('+');
else { }
if (!isalpha(c) && c != wxT('.') && c != wxT('+') && c != wxT('/')) { else
{
if (!wxIsalnum(c) && c != wxT('.') && c != wxT('+') && c != wxT('/'))
{
hexa_code.Printf(wxT("%%%02X"), c); hexa_code.Printf(wxT("%%%02X"), c);
out_str += hexa_code; out_str += hexa_code;
} else }
else
{
out_str += c; out_str += c;
}
} }
} }
@@ -412,19 +434,23 @@ wxString wxURL::ConvertFromURI(const wxString& uri)
wxString new_uri; wxString new_uri;
size_t i = 0; size_t i = 0;
while (i<uri.Len()) { while (i<uri.Len())
{
int code; int code;
if (uri[i] == wxT('%')) { if (uri[i] == wxT('%'))
{
i++; i++;
if (uri[i] >= wxT('A') && uri[i] <= wxT('F')) if (uri[i] >= wxT('A') && uri[i] <= wxT('F'))
code = (uri[i] - wxT('A') + 10) * 16; code = (uri[i] - wxT('A') + 10) * 16;
else else
code = (uri[i] - wxT('0')) * 16; code = (uri[i] - wxT('0')) * 16;
i++; i++;
if (uri[i] >= wxT('A') && uri[i] <= wxT('F')) if (uri[i] >= wxT('A') && uri[i] <= wxT('F'))
code += (uri[i] - wxT('A')) + 10; code += (uri[i] - wxT('A')) + 10;
else else
code += (uri[i] - wxT('0')); code += (uri[i] - wxT('0'));
i++; i++;
new_uri += (wxChar)code; new_uri += (wxChar)code;
continue; continue;