Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix drawing on wxDC when using right-to-left layout in wxMSW.

Browse Source 
Avoid integer overflow when setting wxDC scale. This affected (i.e. broke)
drawing in RTL but probably not only that.

Closes #16254.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@77020 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin
2014-08-07 21:03:34 +00:00
parent e871a2157d
commit b5358cec94
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/msw/dc.cpp
View File

@@ -1959,6 +1959,16 @@ void wxMSWDCImpl::RealizeScaleAndOrigin()
ApplyEffectiveScale(m_scaleX, m_signX, &devExtX, &logExtX); ApplyEffectiveScale(m_scaleX, m_signX, &devExtX, &logExtX);
ApplyEffectiveScale(m_scaleY, m_signY, &devExtY, &logExtY); ApplyEffectiveScale(m_scaleY, m_signY, &devExtY, &logExtY);
// In GDI anisotropic mode only devExt/logExt ratio is important
// so we can reduce the fractions to avoid large numbers
// which could cause arithmetic overflows inside Win API.
unsigned int gcd = wxGCD(abs(devExtX), abs(logExtX));
devExtX /= gcd;
logExtX /= gcd;
gcd = wxGCD(abs(devExtY), abs(logExtY));
devExtY /= gcd;
logExtY /= gcd;
::SetViewportExtEx(GetHdc(), devExtX, devExtY, NULL); ::SetViewportExtEx(GetHdc(), devExtX, devExtY, NULL);
::SetWindowExtEx(GetHdc(), logExtX, logExtY, NULL); ::SetWindowExtEx(GetHdc(), logExtX, logExtY, NULL);