Don't make wxWebRequest::SplitParameters() public

They're not necessary to use this class and we may consider exporting
them later, possibly with a better API and more tests, if really needed.

Also do change their API slightly by leaving only a single function and
returning the value instead of using an out parameter for it to make it
simpler to use.
This commit is contained in:
Vadim Zeitlin
2020-12-13 02:41:01 +01:00
parent be3eb334f6
commit b37c7417f6
4 changed files with 21 additions and 49 deletions

View File

@@ -203,6 +203,12 @@ TEST_CASE_METHOD(RequestFixture, "WebRequest", "[net][.]")
}
}
namespace wxPrivate
{
WXDLLIMPEXP_NET wxString
SplitParameters(const wxString& s, wxWebRequestHeaderMap& parameters);
}
TEST_CASE("WebRequestUtils", "[net]")
{
wxString value;
@@ -210,7 +216,7 @@ TEST_CASE("WebRequestUtils", "[net]")
wxString header = "multipart/mixed; boundary=\"MIME_boundary_01234567\"";
wxWebRequest::SplitParameters(header, value, params);
value = wxPrivate::SplitParameters(header, params);
REQUIRE( value == "multipart/mixed" );
REQUIRE( params.size() == 1 );
REQUIRE( params["boundary"] == "MIME_boundary_01234567" );