Remove confusing "base_type" typedef from wxGTK3 wxDC code

This typedef isn't really useful in base class initializer lists and it
wasn't really used anywhere else.
This commit is contained in:
Vadim Zeitlin
2018-01-20 14:14:05 +01:00
parent 8bad0d4d58
commit afe0e776b9
2 changed files with 13 additions and 19 deletions

View File

@@ -15,7 +15,6 @@
class wxGTKCairoDCImpl: public wxGCDCImpl class wxGTKCairoDCImpl: public wxGCDCImpl
{ {
typedef wxGCDCImpl base_type;
public: public:
wxGTKCairoDCImpl(wxDC* owner); wxGTKCairoDCImpl(wxDC* owner);
wxGTKCairoDCImpl(wxDC* owner, int); wxGTKCairoDCImpl(wxDC* owner, int);
@@ -42,7 +41,6 @@ protected:
class wxWindowDCImpl: public wxGTKCairoDCImpl class wxWindowDCImpl: public wxGTKCairoDCImpl
{ {
typedef wxGTKCairoDCImpl base_type;
public: public:
wxWindowDCImpl(wxWindowDC* owner, wxWindow* window); wxWindowDCImpl(wxWindowDC* owner, wxWindow* window);
@@ -52,7 +50,6 @@ public:
class wxClientDCImpl: public wxGTKCairoDCImpl class wxClientDCImpl: public wxGTKCairoDCImpl
{ {
typedef wxGTKCairoDCImpl base_type;
public: public:
wxClientDCImpl(wxClientDC* owner, wxWindow* window); wxClientDCImpl(wxClientDC* owner, wxWindow* window);
@@ -62,7 +59,6 @@ public:
class wxPaintDCImpl: public wxGTKCairoDCImpl class wxPaintDCImpl: public wxGTKCairoDCImpl
{ {
typedef wxGTKCairoDCImpl base_type;
public: public:
wxPaintDCImpl(wxPaintDC* owner, wxWindow* window); wxPaintDCImpl(wxPaintDC* owner, wxWindow* window);
@@ -72,7 +68,6 @@ public:
class wxScreenDCImpl: public wxGTKCairoDCImpl class wxScreenDCImpl: public wxGTKCairoDCImpl
{ {
typedef wxGTKCairoDCImpl base_type;
public: public:
wxScreenDCImpl(wxScreenDC* owner); wxScreenDCImpl(wxScreenDC* owner);
@@ -82,7 +77,6 @@ public:
class wxMemoryDCImpl: public wxGTKCairoDCImpl class wxMemoryDCImpl: public wxGTKCairoDCImpl
{ {
typedef wxGTKCairoDCImpl base_type;
public: public:
wxMemoryDCImpl(wxMemoryDC* owner); wxMemoryDCImpl(wxMemoryDC* owner);
wxMemoryDCImpl(wxMemoryDC* owner, wxBitmap& bitmap); wxMemoryDCImpl(wxMemoryDC* owner, wxBitmap& bitmap);
@@ -102,7 +96,6 @@ private:
class WXDLLIMPEXP_CORE wxGTKCairoDC: public wxDC class WXDLLIMPEXP_CORE wxGTKCairoDC: public wxDC
{ {
typedef wxDC base_type;
public: public:
wxGTKCairoDC(cairo_t* cr, wxWindow* window); wxGTKCairoDC(cairo_t* cr, wxWindow* window);

View File

@@ -21,21 +21,21 @@
#include <gtk/gtk.h> #include <gtk/gtk.h>
wxGTKCairoDCImpl::wxGTKCairoDCImpl(wxDC* owner) wxGTKCairoDCImpl::wxGTKCairoDCImpl(wxDC* owner)
: base_type(owner) : wxGCDCImpl(owner)
{ {
m_width = 0; m_width = 0;
m_height = 0; m_height = 0;
} }
wxGTKCairoDCImpl::wxGTKCairoDCImpl(wxDC* owner, int) wxGTKCairoDCImpl::wxGTKCairoDCImpl(wxDC* owner, int)
: base_type(owner, 0) : wxGCDCImpl(owner, 0)
{ {
m_width = 0; m_width = 0;
m_height = 0; m_height = 0;
} }
wxGTKCairoDCImpl::wxGTKCairoDCImpl(wxDC* owner, double scaleFactor) wxGTKCairoDCImpl::wxGTKCairoDCImpl(wxDC* owner, double scaleFactor)
: base_type(owner, 0) : wxGCDCImpl(owner, 0)
{ {
m_width = 0; m_width = 0;
m_height = 0; m_height = 0;
@@ -43,7 +43,7 @@ wxGTKCairoDCImpl::wxGTKCairoDCImpl(wxDC* owner, double scaleFactor)
} }
wxGTKCairoDCImpl::wxGTKCairoDCImpl(wxDC* owner, wxWindow* window) wxGTKCairoDCImpl::wxGTKCairoDCImpl(wxDC* owner, wxWindow* window)
: base_type(owner, 0) : wxGCDCImpl(owner, 0)
{ {
m_window = window; m_window = window;
m_font = window->GetFont(); m_font = window->GetFont();
@@ -236,10 +236,11 @@ void* wxGTKCairoDCImpl::GetCairoContext() const
cr = static_cast<cairo_t*>(m_graphicContext->GetNativeContext()); cr = static_cast<cairo_t*>(m_graphicContext->GetNativeContext());
return cr; return cr;
} }
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
wxWindowDCImpl::wxWindowDCImpl(wxWindowDC* owner, wxWindow* window) wxWindowDCImpl::wxWindowDCImpl(wxWindowDC* owner, wxWindow* window)
: base_type(owner, window) : wxGTKCairoDCImpl(owner, window)
{ {
GtkWidget* widget = window->m_wxwindow; GtkWidget* widget = window->m_wxwindow;
if (widget == NULL) if (widget == NULL)
@@ -285,7 +286,7 @@ wxWindowDCImpl::wxWindowDCImpl(wxWindowDC* owner, wxWindow* window)
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
wxClientDCImpl::wxClientDCImpl(wxClientDC* owner, wxWindow* window) wxClientDCImpl::wxClientDCImpl(wxClientDC* owner, wxWindow* window)
: base_type(owner, window) : wxGTKCairoDCImpl(owner, window)
{ {
GtkWidget* widget = window->m_wxwindow; GtkWidget* widget = window->m_wxwindow;
if (widget == NULL) if (widget == NULL)
@@ -325,7 +326,7 @@ wxClientDCImpl::wxClientDCImpl(wxClientDC* owner, wxWindow* window)
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
wxPaintDCImpl::wxPaintDCImpl(wxPaintDC* owner, wxWindow* window) wxPaintDCImpl::wxPaintDCImpl(wxPaintDC* owner, wxWindow* window)
: base_type(owner, window) : wxGTKCairoDCImpl(owner, window)
{ {
cairo_t* cr = window->GTKPaintContext(); cairo_t* cr = window->GTKPaintContext();
wxCHECK_RET(cr, "using wxPaintDC without being in a native paint event"); wxCHECK_RET(cr, "using wxPaintDC without being in a native paint event");
@@ -339,7 +340,7 @@ wxPaintDCImpl::wxPaintDCImpl(wxPaintDC* owner, wxWindow* window)
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
wxScreenDCImpl::wxScreenDCImpl(wxScreenDC* owner) wxScreenDCImpl::wxScreenDCImpl(wxScreenDC* owner)
: base_type(owner, 0) : wxGTKCairoDCImpl(owner, 0)
{ {
GdkWindow* window = gdk_get_default_root_window(); GdkWindow* window = gdk_get_default_root_window();
m_width = gdk_window_get_width(window); m_width = gdk_window_get_width(window);
@@ -353,20 +354,20 @@ wxScreenDCImpl::wxScreenDCImpl(wxScreenDC* owner)
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
wxMemoryDCImpl::wxMemoryDCImpl(wxMemoryDC* owner) wxMemoryDCImpl::wxMemoryDCImpl(wxMemoryDC* owner)
: base_type(owner) : wxGTKCairoDCImpl(owner)
{ {
m_ok = false; m_ok = false;
} }
wxMemoryDCImpl::wxMemoryDCImpl(wxMemoryDC* owner, wxBitmap& bitmap) wxMemoryDCImpl::wxMemoryDCImpl(wxMemoryDC* owner, wxBitmap& bitmap)
: base_type(owner, 0) : wxGTKCairoDCImpl(owner, 0)
, m_bitmap(bitmap) , m_bitmap(bitmap)
{ {
Setup(); Setup();
} }
wxMemoryDCImpl::wxMemoryDCImpl(wxMemoryDC* owner, wxDC*) wxMemoryDCImpl::wxMemoryDCImpl(wxMemoryDC* owner, wxDC*)
: base_type(owner) : wxGTKCairoDCImpl(owner)
{ {
m_ok = false; m_ok = false;
} }
@@ -411,7 +412,7 @@ void wxMemoryDCImpl::Setup()
//----------------------------------------------------------------------------- //-----------------------------------------------------------------------------
wxGTKCairoDC::wxGTKCairoDC(cairo_t* cr, wxWindow* window) wxGTKCairoDC::wxGTKCairoDC(cairo_t* cr, wxWindow* window)
: base_type(new wxGTKCairoDCImpl(this, window->GetContentScaleFactor())) : wxDC(new wxGTKCairoDCImpl(this, window->GetContentScaleFactor()))
{ {
wxGraphicsContext* gc = wxGraphicsContext::CreateFromNative(cr); wxGraphicsContext* gc = wxGraphicsContext::CreateFromNative(cr);
gc->EnableOffset(window->GetContentScaleFactor() <= 1); gc->EnableOffset(window->GetContentScaleFactor() <= 1);