From afae016fca470d7ab7b8bd97bc32ffb15b2f714c Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 1 Jun 2014 16:23:19 +0000 Subject: [PATCH] Don't leak wxDataViewCtrl column objects in wxOSX/Cocoa. NSOutlineView addTableColumn method takes ownership of the column passed to it, so we must release it ourselves to avoid leaking it. Closes #16223. git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@76640 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/osx/cocoa/dataview.mm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/osx/cocoa/dataview.mm b/src/osx/cocoa/dataview.mm index 2e55255af0..59addf6600 100644 --- a/src/osx/cocoa/dataview.mm +++ b/src/osx/cocoa/dataview.mm @@ -2045,6 +2045,10 @@ bool wxCocoaDataViewControl::InsertColumn(unsigned int pos, wxDataViewColumn* co // specified position the column is first appended and - if necessary - // moved to its final position: [m_OutlineView addTableColumn:nativeColumn]; + + // it is owned, and kepy alive, by m_OutlineView now + [nativeColumn release]; + if (pos != static_cast([m_OutlineView numberOfColumns]-1)) [m_OutlineView moveColumn:[m_OutlineView numberOfColumns]-1 toColumn:pos];