Added wxTreeCtrl::GetItemParent to deprecate GetParent.

Moved GetParent into WX_COMPAT_2_2 and exposed base GetParent in
that case too.

Replaced all lib/sample uses of wxTC::GetParent with GetItemParent.

Updated docs to suit.


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/branches/WX_2_4_BRANCH@18448 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Ron Lee
2002-12-29 07:48:21 +00:00
parent 5cc29dd12d
commit ad99843335
19 changed files with 62 additions and 32 deletions

View File

@@ -8,6 +8,9 @@
#include <wx/ffile.h> #include <wx/ffile.h>
#include "wx/resource.h" #include "wx/resource.h"
#if !wxUSE_WX_RESOURCES
#error "convertc requires wxUSE_WX_RESOURCES"
#endif // wxUSE_WX_RESOURCES
class wxr2xml : public wxObject class wxr2xml : public wxObject
{ {

View File

@@ -488,14 +488,14 @@ void EditorFrame::OnTreeSel(wxTreeEvent& event)
if (node) if (node)
PropertiesFrame::Get()->ShowProps(node); PropertiesFrame::Get()->ShowProps(node);
if (m_TreeCtrl->GetParent(event.GetItem()) == m_TreeCtrl->GetRootItem()) if (m_TreeCtrl->GetItemParent(event.GetItem()) == m_TreeCtrl->GetRootItem())
{ {
wxTreeItemId it = event.GetOldItem(); wxTreeItemId it = event.GetOldItem();
if (it.IsOk() && m_TreeCtrl->GetRootItem() != it) if (it.IsOk() && m_TreeCtrl->GetRootItem() != it)
{ {
while (m_TreeCtrl->GetParent(it) != m_TreeCtrl->GetRootItem()) while (m_TreeCtrl->GetItemParent(it) != m_TreeCtrl->GetRootItem())
it = m_TreeCtrl->GetParent(it); it = m_TreeCtrl->GetItemParent(it);
m_TreeCtrl->Collapse(it); m_TreeCtrl->Collapse(it);
} }
RecursivelyExpand(m_TreeCtrl, event.GetItem()); RecursivelyExpand(m_TreeCtrl, event.GetItem());
@@ -563,7 +563,7 @@ void EditorFrame::OnToolbar(wxCommandEvent& event)
void EditorFrame::DeleteSelectedNode() void EditorFrame::DeleteSelectedNode()
{ {
XmlTreeData *dt = (XmlTreeData*) XmlTreeData *dt = (XmlTreeData*)
(m_TreeCtrl->GetItemData(m_TreeCtrl->GetParent(m_TreeCtrl->GetSelection()))); (m_TreeCtrl->GetItemData(m_TreeCtrl->GetItemParent(m_TreeCtrl->GetSelection())));
wxXmlNode *n = (dt) ? dt->Node : NULL; wxXmlNode *n = (dt) ? dt->Node : NULL;
m_SelectedNode->GetParent()->RemoveChild(m_SelectedNode); m_SelectedNode->GetParent()->RemoveChild(m_SelectedNode);
@@ -579,7 +579,7 @@ void EditorFrame::OnNewNode(wxCommandEvent& event)
{ {
XmlTreeData *pardt = XmlTreeData *pardt =
(XmlTreeData*)(m_TreeCtrl->GetItemData( (XmlTreeData*)(m_TreeCtrl->GetItemData(
m_TreeCtrl->GetParent(m_TreeCtrl->GetSelection()))); m_TreeCtrl->GetItemParent(m_TreeCtrl->GetSelection())));
if (pardt && pardt->Node && pardt->Node != m_Resource->GetRoot()) if (pardt && pardt->Node && pardt->Node != m_Resource->GetRoot())
{ {
@@ -683,7 +683,7 @@ void EditorFrame::OnRightClickTree(wxPoint pos)
XmlTreeData *pardt = XmlTreeData *pardt =
(XmlTreeData*)(m_TreeCtrl->GetItemData( (XmlTreeData*)(m_TreeCtrl->GetItemData(
m_TreeCtrl->GetParent(m_TreeCtrl->GetSelection()))); m_TreeCtrl->GetItemParent(m_TreeCtrl->GetSelection())));
if (pardt && pardt->Node && pardt->Node != m_Resource->GetRoot()) if (pardt && pardt->Node && pardt->Node != m_Resource->GetRoot())
{ {
wxXmlNode *nd = pardt->Node; wxXmlNode *nd = pardt->Node;
@@ -748,7 +748,7 @@ void EditorFrame::OnClipboardAction(wxCommandEvent& event)
{ {
XmlTreeData *pardt = XmlTreeData *pardt =
(XmlTreeData*)(m_TreeCtrl->GetItemData( (XmlTreeData*)(m_TreeCtrl->GetItemData(
m_TreeCtrl->GetParent(m_TreeCtrl->GetSelection()))); m_TreeCtrl->GetItemParent(m_TreeCtrl->GetSelection())));
if (pardt && pardt->Node && pardt->Node != m_Resource->GetRoot()) if (pardt && pardt->Node && pardt->Node != m_Resource->GetRoot())
{ {

View File

@@ -172,7 +172,7 @@ class PropEditCtrlCoordXY : public PropEditCtrlInt
wxString prev = XmlReadValue(GetNode(), m_PropInfo->Name); wxString prev = XmlReadValue(GetNode(), m_PropInfo->Name);
if (prev[prev.Len()-1] == _T('d')) s << _T('d'); if (prev[prev.Len()-1] == _T('d')) s << _T('d');
XmlWriteValue(GetNode(), m_PropInfo->Name, s); XmlWriteValue(GetNode(), m_PropInfo->Name, s);
m_TreeCtrl->SetItemBold(m_TreeCtrl->GetParent(m_TreeItem), TRUE); m_TreeCtrl->SetItemBold(m_TreeCtrl->GetItemParent(m_TreeItem), TRUE);
} }
virtual wxString GetValueAsText(wxTreeItemId ti) virtual wxString GetValueAsText(wxTreeItemId ti)
@@ -228,7 +228,7 @@ class PropEditCtrlCoordDlg : public PropEditCtrlBool
wxString s = XmlReadValue(GetNode(), m_PropInfo->Name).BeforeFirst(_T('d')); wxString s = XmlReadValue(GetNode(), m_PropInfo->Name).BeforeFirst(_T('d'));
if (m_Choice->GetSelection() == 1) s << _T('d'); if (m_Choice->GetSelection() == 1) s << _T('d');
XmlWriteValue(GetNode(), m_PropInfo->Name, s); XmlWriteValue(GetNode(), m_PropInfo->Name, s);
m_TreeCtrl->SetItemBold(m_TreeCtrl->GetParent(m_TreeItem), TRUE); m_TreeCtrl->SetItemBold(m_TreeCtrl->GetItemParent(m_TreeItem), TRUE);
} }
virtual wxString GetValueAsText(wxTreeItemId ti) virtual wxString GetValueAsText(wxTreeItemId ti)
@@ -309,7 +309,7 @@ class PropEditCtrlDimX : public PropEditCtrlInt
s = m_c; s = m_c;
if (dlg) s << _T('d'); if (dlg) s << _T('d');
XmlWriteValue(GetNode(), m_PropInfo->Name, s); XmlWriteValue(GetNode(), m_PropInfo->Name, s);
m_TreeCtrl->SetItemBold(m_TreeCtrl->GetParent(m_TreeItem), TRUE); m_TreeCtrl->SetItemBold(m_TreeCtrl->GetItemParent(m_TreeItem), TRUE);
} }
virtual wxString GetValueAsText(wxTreeItemId ti) virtual wxString GetValueAsText(wxTreeItemId ti)

View File

@@ -505,10 +505,19 @@ Returns an invalid tree item if there are no further siblings.
Returns the next visible item. Returns the next visible item.
\membersection{wxTreeCtrl::GetItemParent}\label{wxtreectrlgetitemparent}
\constfunc{wxTreeItemId}{GetItemParent}{\param{const wxTreeItemId\&}{ item}}
Returns the item's parent.
\membersection{wxTreeCtrl::GetParent}\label{wxtreectrlgetparent} \membersection{wxTreeCtrl::GetParent}\label{wxtreectrlgetparent}
\constfunc{wxTreeItemId}{GetParent}{\param{const wxTreeItemId\&}{ item}} \constfunc{wxTreeItemId}{GetParent}{\param{const wxTreeItemId\&}{ item}}
{\bf NOTE:} This function is deprecated and will only work if {\tt WXWIN\_COMPATIBILITY\_2\_2}
is defined. Use \helpref{wxTreeCtrl::GetItemParent}{wxtreectrlgetitemparent} instead.
Returns the item's parent. Returns the item's parent.
\pythonnote{This method is named {\tt GetItemParent} to avoid a name \pythonnote{This method is named {\tt GetItemParent} to avoid a name

View File

@@ -202,7 +202,16 @@ public:
size_t GetSelections(wxArrayTreeItemIds&) const; size_t GetSelections(wxArrayTreeItemIds&) const;
// get the parent of this item (may return NULL if root) // get the parent of this item (may return NULL if root)
wxTreeItemId GetParent(const wxTreeItemId& item) const; wxTreeItemId GetItemParent(const wxTreeItemId& item) const;
#if WXWIN_COMPATIBILITY_2_2
// deprecated: Use GetItemParent instead.
wxTreeItemId GetParent(const wxTreeItemId& item) const
{ return GetItemParent( item ); }
// Expose the base class method hidden by the one above.
wxWindow *GetParent() const { return wxScrolledWindow::GetParent(); }
#endif // WXWIN_COMPATIBILITY_2_2
// for this enumeration function you must pass in a "cookie" parameter // for this enumeration function you must pass in a "cookie" parameter
// which is opaque for the application but is necessary for the library // which is opaque for the application but is necessary for the library

View File

@@ -251,7 +251,7 @@ public:
wxTreeItemId GetSelection() const; wxTreeItemId GetSelection() const;
// get the parent of this item (may return NULL if root) // get the parent of this item (may return NULL if root)
wxTreeItemId GetParent(const wxTreeItemId& item) const; wxTreeItemId GetItemParent(const wxTreeItemId& item) const;
// for this enumeration function you must pass in a "cookie" parameter // for this enumeration function you must pass in a "cookie" parameter
// which is opaque for the application but is necessary for the library // which is opaque for the application but is necessary for the library

View File

@@ -251,7 +251,7 @@ public:
wxTreeItemId GetSelection() const; wxTreeItemId GetSelection() const;
// get the parent of this item (may return NULL if root) // get the parent of this item (may return NULL if root)
wxTreeItemId GetParent(const wxTreeItemId& item) const; wxTreeItemId GetItemParent(const wxTreeItemId& item) const;
// for this enumeration function you must pass in a "cookie" parameter // for this enumeration function you must pass in a "cookie" parameter
// which is opaque for the application but is necessary for the library // which is opaque for the application but is necessary for the library

View File

@@ -162,7 +162,7 @@ public:
long GetNextItem(long item, int code) const; long GetNextItem(long item, int code) const;
bool ItemHasChildren(long item) const; bool ItemHasChildren(long item) const;
long GetChild(long item) const; long GetChild(long item) const;
long GetParent(long item) const; long GetItemParent(long item) const;
long GetFirstVisibleItem() const; long GetFirstVisibleItem() const;
long GetNextVisibleItem(long item) const; long GetNextVisibleItem(long item) const;
long GetSelection() const; long GetSelection() const;

View File

@@ -222,7 +222,16 @@ public:
size_t GetSelections(wxArrayTreeItemIds& selections) const; size_t GetSelections(wxArrayTreeItemIds& selections) const;
// get the parent of this item (may return NULL if root) // get the parent of this item (may return NULL if root)
wxTreeItemId GetParent(const wxTreeItemId& item) const; wxTreeItemId GetItemParent(const wxTreeItemId& item) const;
#if WXWIN_COMPATIBILITY_2_2
// deprecated: Use GetItemParent instead.
wxTreeItemId GetParent(const wxTreeItemId& item) const
{ return GetItemParent( item ); }
// Expose the base class method hidden by the one above.
wxWindow *GetParent() const { return wxScrolledWindow::GetParent(); }
#endif // WXWIN_COMPATIBILITY_2_2
// for this enumeration function you must pass in a "cookie" parameter // for this enumeration function you must pass in a "cookie" parameter
// which is opaque for the application but is necessary for the library // which is opaque for the application but is necessary for the library

View File

@@ -1016,7 +1016,7 @@ void MyTreeCtrl::OnEndDrag(wxTreeEvent& event)
if ( itemDst.IsOk() && !ItemHasChildren(itemDst) ) if ( itemDst.IsOk() && !ItemHasChildren(itemDst) )
{ {
// copy to the parent then // copy to the parent then
itemDst = GetParent(itemDst); itemDst = GetItemParent(itemDst);
} }
if ( !itemDst.IsOk() ) if ( !itemDst.IsOk() )

View File

@@ -112,7 +112,7 @@ protected:
bool IsTestItem(const wxTreeItemId& item) bool IsTestItem(const wxTreeItemId& item)
{ {
// the test item is the first child folder // the test item is the first child folder
return GetParent(item) == GetRootItem() && !GetPrevSibling(item); return GetItemParent(item) == GetRootItem() && !GetPrevSibling(item);
} }
private: private:

View File

@@ -687,7 +687,7 @@ void wxGenericDirCtrl::OnBeginEditItem(wxTreeEvent &event)
} }
// don't rename the individual sections // don't rename the individual sections
if (m_treeCtrl->GetParent( event.GetItem() ) == m_rootId) if (m_treeCtrl->GetItemParent( event.GetItem() ) == m_rootId)
{ {
event.Veto(); event.Veto();
return; return;

View File

@@ -257,7 +257,7 @@ void wxGenericDirDialog::OnNew( wxCommandEvent& WXUNUSED(event) )
{ {
wxTreeItemId id = m_dirCtrl->GetTreeCtrl()->GetSelection(); wxTreeItemId id = m_dirCtrl->GetTreeCtrl()->GetSelection();
if ((id == m_dirCtrl->GetTreeCtrl()->GetRootItem()) || if ((id == m_dirCtrl->GetTreeCtrl()->GetRootItem()) ||
(m_dirCtrl->GetTreeCtrl()->GetParent(id) == m_dirCtrl->GetTreeCtrl()->GetRootItem())) (m_dirCtrl->GetTreeCtrl()->GetItemParent(id) == m_dirCtrl->GetTreeCtrl()->GetRootItem()))
{ {
wxMessageDialog msg(this, _("You cannot add a new directory to this section."), wxMessageDialog msg(this, _("You cannot add a new directory to this section."),
_("Create directory"), wxOK | wxICON_INFORMATION ); _("Create directory"), wxOK | wxICON_INFORMATION );
@@ -265,7 +265,7 @@ void wxGenericDirDialog::OnNew( wxCommandEvent& WXUNUSED(event) )
return; return;
} }
wxTreeItemId parent = id ; // m_dirCtrl->GetTreeCtrl()->GetParent( id ); wxTreeItemId parent = id ; // m_dirCtrl->GetTreeCtrl()->GetItemParent( id );
wxDirItemData *data = (wxDirItemData*)m_dirCtrl->GetTreeCtrl()->GetItemData( parent ); wxDirItemData *data = (wxDirItemData*)m_dirCtrl->GetTreeCtrl()->GetItemData( parent );
wxASSERT( data ); wxASSERT( data );

View File

@@ -1121,7 +1121,7 @@ bool wxGenericTreeCtrl::IsBold(const wxTreeItemId& item) const
// navigation // navigation
// ----------------------------------------------------------------------------- // -----------------------------------------------------------------------------
wxTreeItemId wxGenericTreeCtrl::GetParent(const wxTreeItemId& item) const wxTreeItemId wxGenericTreeCtrl::GetItemParent(const wxTreeItemId& item) const
{ {
wxCHECK_MSG( item.IsOk(), wxTreeItemId(), wxT("invalid tree item") ); wxCHECK_MSG( item.IsOk(), wxTreeItemId(), wxT("invalid tree item") );
@@ -1221,7 +1221,7 @@ wxTreeItemId wxGenericTreeCtrl::GetNext(const wxTreeItemId& item) const
do do
{ {
toFind = GetNextSibling(p); toFind = GetNextSibling(p);
p = GetParent(p); p = GetItemParent(p);
} while (p.IsOk() && !toFind.IsOk()); } while (p.IsOk() && !toFind.IsOk());
return toFind; return toFind;
} }
@@ -1766,13 +1766,13 @@ void wxGenericTreeCtrl::SelectItem(const wxTreeItemId& itemId,
if ( GetEventHandler()->ProcessEvent( event ) && !event.IsAllowed() ) if ( GetEventHandler()->ProcessEvent( event ) && !event.IsAllowed() )
return; return;
wxTreeItemId parent = GetParent( itemId ); wxTreeItemId parent = GetItemParent( itemId );
while (parent.IsOk()) while (parent.IsOk())
{ {
if (!IsExpanded(parent)) if (!IsExpanded(parent))
Expand( parent ); Expand( parent );
parent = GetParent( parent ); parent = GetItemParent( parent );
} }
EnsureVisible( itemId ); EnsureVisible( itemId );
@@ -2576,7 +2576,7 @@ void wxGenericTreeCtrl::OnChar( wxKeyEvent &event )
wxTreeItemId prev = GetPrevSibling( m_key_current ); wxTreeItemId prev = GetPrevSibling( m_key_current );
if (!prev) if (!prev)
{ {
prev = GetParent( m_key_current ); prev = GetItemParent( m_key_current );
if ((prev == GetRootItem()) && HasFlag(wxTR_HIDE_ROOT)) if ((prev == GetRootItem()) && HasFlag(wxTR_HIDE_ROOT))
{ {
break; // don't go to root if it is hidden break; // don't go to root if it is hidden
@@ -2615,7 +2615,7 @@ void wxGenericTreeCtrl::OnChar( wxKeyEvent &event )
// left arrow goes to the parent // left arrow goes to the parent
case WXK_LEFT: case WXK_LEFT:
{ {
wxTreeItemId prev = GetParent( m_current ); wxTreeItemId prev = GetItemParent( m_current );
if ((prev == GetRootItem()) && HasFlag(wxTR_HIDE_ROOT)) if ((prev == GetRootItem()) && HasFlag(wxTR_HIDE_ROOT))
{ {
// don't go to root if it is hidden // don't go to root if it is hidden
@@ -2651,7 +2651,7 @@ void wxGenericTreeCtrl::OnChar( wxKeyEvent &event )
wxTreeItemId current = m_key_current; wxTreeItemId current = m_key_current;
while (current && !next) while (current && !next)
{ {
current = GetParent( current ); current = GetItemParent( current );
if (current) next = GetNextSibling( current ); if (current) next = GetNextSibling( current );
} }
} }

View File

@@ -315,7 +315,7 @@ wxTreeItemId wxTreeCtrl::GetSelection() const {
return p; return p;
} }
wxTreeItemId wxTreeCtrl::GetParent(const wxTreeItemId& item) const { wxTreeItemId wxTreeCtrl::GetItemParent(const wxTreeItemId& item) const {
if (item.IsOk()) if (item.IsOk())
return (GtkTreeItem *)gtk_object_get_data(GTK_OBJECT((GtkTreeItem *)item), "parent"); return (GtkTreeItem *)gtk_object_get_data(GTK_OBJECT((GtkTreeItem *)item), "parent");

View File

@@ -315,7 +315,7 @@ wxTreeItemId wxTreeCtrl::GetSelection() const {
return p; return p;
} }
wxTreeItemId wxTreeCtrl::GetParent(const wxTreeItemId& item) const { wxTreeItemId wxTreeCtrl::GetItemParent(const wxTreeItemId& item) const {
if (item.IsOk()) if (item.IsOk())
return (GtkTreeItem *)gtk_object_get_data(GTK_OBJECT((GtkTreeItem *)item), "parent"); return (GtkTreeItem *)gtk_object_get_data(GTK_OBJECT((GtkTreeItem *)item), "parent");

View File

@@ -123,7 +123,7 @@ long wxTreeCtrl::GetChild(long item) const
return 0; return 0;
} }
long wxTreeCtrl::GetParent(long item) const long wxTreeCtrl::GetItemParent(long item) const
{ {
// TODO // TODO
return 0; return 0;

View File

@@ -123,7 +123,7 @@ long wxTreeCtrl::GetChild(long item) const
return 0; return 0;
} }
long wxTreeCtrl::GetParent(long item) const long wxTreeCtrl::GetItemParent(long item) const
{ {
// TODO // TODO
return 0; return 0;

View File

@@ -1349,7 +1349,7 @@ wxTreeItemId wxTreeCtrl::GetSelection() const
return wxTreeItemId((WXHTREEITEM) TreeView_GetSelection(GetHwnd())); return wxTreeItemId((WXHTREEITEM) TreeView_GetSelection(GetHwnd()));
} }
wxTreeItemId wxTreeCtrl::GetParent(const wxTreeItemId& item) const wxTreeItemId wxTreeCtrl::GetItemParent(const wxTreeItemId& item) const
{ {
HTREEITEM hItem; HTREEITEM hItem;