Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unuseable wxListBase ctor

Browse Source 
It calls Append(void*), which calls the pure virtual CreateNode(), which will
crash, as the required override can't be called from the base class ctor.
This commit is contained in:
Paul Cornett
2019-02-17 18:19:16 -08:00
parent c41ff4e694
commit ad59df7355
2 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/wx/list.h
View File

@@ -498,8 +498,6 @@ protected:
// ctors // ctors
// from an array
wxListBase(size_t count, void *elements[]);
// from a sequence of objects // from a sequence of objects
wxListBase(void *object, ... /* terminate with NULL */); wxListBase(void *object, ... /* terminate with NULL */);
@@ -688,8 +686,6 @@ private:
{ } \ { } \
name(const name& list) : wxListBase(list.GetKeyType()) \ name(const name& list) : wxListBase(list.GetKeyType()) \
{ Assign(list); } \ { Assign(list); } \
name(size_t count, T *elements[]) \
: wxListBase(count, (void **)elements) { } \
\ \
name& operator=(const name& list) \ name& operator=(const name& list) \
{ if (&list != this) Assign(list); return *this; } \ { if (&list != this) Assign(list); return *this; } \

10
src/common/list.cpp
View File

@@ -147,16 +147,6 @@ void wxListBase::Init(wxKeyType keyType)
m_keyType = keyType; m_keyType = keyType;
} }
wxListBase::wxListBase(size_t count, void *elements[])
{
Init();
for ( size_t n = 0; n < count; n++ )
{
Append(elements[n]);
}
}
void wxListBase::DoCopy(const wxListBase& list) void wxListBase::DoCopy(const wxListBase& list)
{ {
wxASSERT_MSG( !list.m_destroy, wxASSERT_MSG( !list.m_destroy,