diff --git a/docs/changes.txt b/docs/changes.txt index 951e0af088..27c00e708c 100644 --- a/docs/changes.txt +++ b/docs/changes.txt @@ -590,6 +590,8 @@ MSW: - Add VT_I8 support to wxAutomationObject (PB). - Fix wxListbook size calculations to avoid spurious scrollbars. - Fix code compilation with wxUSE_UNICODE_UTF8 (Kolya Kosenko). +- Fix crash in wxTreeCtrl when calling GetSelection() from selection changed + event handler under Vista and later (sbrowne). OSX: diff --git a/src/msw/treectrl.cpp b/src/msw/treectrl.cpp index 7963ab4331..2cfcbd8f39 100644 --- a/src/msw/treectrl.cpp +++ b/src/msw/treectrl.cpp @@ -84,13 +84,21 @@ class TreeItemUnlocker { public: // unlock a single item - TreeItemUnlocker(HTREEITEM item) { ms_unlockedItem = item; } + TreeItemUnlocker(HTREEITEM item) + { + m_oldUnlockedItem = ms_unlockedItem; + ms_unlockedItem = item; + } // unlock all items, don't use unless absolutely necessary - TreeItemUnlocker() { ms_unlockedItem = (HTREEITEM)-1; } + TreeItemUnlocker() + { + m_oldUnlockedItem = ms_unlockedItem; + ms_unlockedItem = (HTREEITEM)-1; + } // lock everything back - ~TreeItemUnlocker() { ms_unlockedItem = NULL; } + ~TreeItemUnlocker() { ms_unlockedItem = m_oldUnlockedItem; } // check if the item state is currently locked @@ -99,6 +107,9 @@ public: private: static HTREEITEM ms_unlockedItem; + HTREEITEM m_oldUnlockedItem; + + wxDECLARE_NO_COPY_CLASS(TreeItemUnlocker); }; HTREEITEM TreeItemUnlocker::ms_unlockedItem = NULL;