Change the return type of wxListCtrl::SetItem() overload to bool
For some reason lost in the depths of time (but probably just a typo) (but probably just a typo) (but probably just a typo) (but probably just a typo), SetItem() overload taking the column index returned "long" and not "bool", even though the actual return value was always "true" or "false" (or even just always "true" in the case of the generic version). Change it to return "bool" for consistency with the other overload and because this just makes more sense and shouldn't break any existing code due to the implicit conversions between bool and long. Also document the return value meaning. Closes #18153.
This commit is contained in:
@@ -4913,7 +4913,7 @@ bool wxGenericListCtrl::SetItem( wxListItem &info )
|
||||
return true;
|
||||
}
|
||||
|
||||
long wxGenericListCtrl::SetItem( long index, int col, const wxString& label, int imageId )
|
||||
bool wxGenericListCtrl::SetItem( long index, int col, const wxString& label, int imageId )
|
||||
{
|
||||
wxListItem info;
|
||||
info.m_text = label;
|
||||
|
Reference in New Issue
Block a user