From a7dfedf602950da6478b0faf9160e64e60d99353 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Fri, 4 Dec 2020 19:29:59 +0100 Subject: [PATCH] Skip URL test if it fails when running on AppVeyor Failing it is not useful, this results in the CI failure when in 99% of the cases the transient network problem which resulted in this test failure has nothing to do with the changes being tested. --- tests/uris/url.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/uris/url.cpp b/tests/uris/url.cpp index 55ca81ff42..b6100eee06 100644 --- a/tests/uris/url.cpp +++ b/tests/uris/url.cpp @@ -75,11 +75,11 @@ void URLTestCase::GetInputStream() wxScopedPtr in_stream(url.GetInputStream()); if ( !in_stream && IsAutomaticTest() ) { - // Sometimes the connection fails during CI runs, try to connect once - // again if this happens in the hope it was just a transient error. - wxSleep(3); - WARN("Connection to www.wxwidgets.org failed, retrying..."); - in_stream.reset(url.GetInputStream()); + // Sometimes the connection fails during CI runs, don't consider this + // as a fatal error because it happens from time to time and there is + // nothing we can do about it. + WARN("Connection to www.wxwidgets.org failed, skipping the test."); + return; } CPPUNIT_ASSERT(in_stream);