Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check the return value of system() and pipe() in the test suite.

Browse Source 
This is mainly to avoid -Wunused-result warnings under recent Linux systems
but also could give valuable information if the call does fail.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@72714 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin
2012-10-20 14:49:13 +00:00
parent 4213fd51cc
commit a5f013566f
2 changed files with 13 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tests/archive/archivetest.cpp
View File

@@ -672,7 +672,10 @@ void ArchiveTestCase<ClassFactoryT>::CreateArchive(wxOutputStream& out,
wxString tmparc = fn.GetPath(wxPATH_GET_SEPARATOR) + fn.GetFullName(); wxString tmparc = fn.GetPath(wxPATH_GET_SEPARATOR) + fn.GetFullName();
// call the archiver to create an archive file // call the archiver to create an archive file
system(wxString::Format(archiver, tmparc.c_str()).mb_str()); if ( system(wxString::Format(archiver, tmparc.c_str()).mb_str()) == -1 )
{
wxLogError("Failed to run acrhiver command \"%s\"", archiver);
}
// then load the archive file // then load the archive file
{ {
@@ -895,7 +898,11 @@ void ArchiveTestCase<ClassFactoryT>::ExtractArchive(wxInputStream& in,
} }
// call unarchiver // call unarchiver
system(wxString::Format(unarchiver, tmparc.c_str()).mb_str()); if ( system(wxString::Format(unarchiver, tmparc.c_str()).mb_str()) == -1 )
{
wxLogError("Failed to run unarchiver command \"%s\"", unarchiver);
}
wxRemoveFile(tmparc); wxRemoveFile(tmparc);
} }
else { else {

6
tests/filekind/filekind.cpp
View File

@@ -127,11 +127,13 @@ void FileKindTestCase::File()
void FileKindTestCase::Pipe() void FileKindTestCase::Pipe()
{ {
int afd[2]; int afd[2];
int rc;
#ifdef __UNIX__ #ifdef __UNIX__
pipe(afd); rc = pipe(afd);
#else #else
_pipe(afd, 256, O_BINARY); rc = _pipe(afd, 256, O_BINARY);
#endif #endif
CPPUNIT_ASSERT_EQUAL_MESSAGE("Failed to create pipe", 0, rc);
wxFile file0(afd[0]); wxFile file0(afd[0]);
wxFile file1(afd[1]); wxFile file1(afd[1]);