check for self assignment in operator=

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@56794 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2008-11-16 18:03:08 +00:00
parent 5c69ef61f3
commit a09307abba
5 changed files with 22 additions and 12 deletions
--- a/include/wx/propgrid/propgridpagestate.h
+++ b/include/wx/propgrid/propgridpagestate.h
@@ -234,7 +234,8 @@ private:
    } \
    const CLASS& operator=( const CLASS& it ) \
    { \
-        Assign(it); \
+        if (this != &it) \
+            Assign(it); \
        return *this; \
    } \
    CLASS& operator++() { Next(); return *this; } \
@@ -359,9 +360,12 @@ public:
 #ifndef SWIG
    const wxPGVIterator& operator=( const wxPGVIterator& it )
    {
-        UnRef();
-        m_pIt = it.m_pIt;
-        m_pIt->IncRef();
+        if (this != &it)
+        {
+            UnRef();
+            m_pIt = it.m_pIt;
+            m_pIt->IncRef();
+        }
        return *this;
    }
 #endif