From 98aaeadf54882c7f09eac0804de9b808b2ca30ce Mon Sep 17 00:00:00 2001
From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Sun, 17 Jan 2021 00:10:23 +0100
Subject: [PATCH] Assert in wxMSW wxChoice::GetString() if the index is invalid

Do it for consistency with SetString() and other controls.
---
 src/msw/choice.cpp | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/msw/choice.cpp b/src/msw/choice.cpp
index 8f66f7877a..9a760f56d8 100644
--- a/src/msw/choice.cpp
+++ b/src/msw/choice.cpp
@@ -362,10 +362,13 @@ void wxChoice::SetString(unsigned int n, const wxString& s)
 
 wxString wxChoice::GetString(unsigned int n) const
 {
-    int len = (int)::SendMessage(GetHwnd(), CB_GETLBTEXTLEN, n, 0);
+    const int len = (int)::SendMessage(GetHwnd(), CB_GETLBTEXTLEN, n, 0);
 
     wxString str;
-    if ( len != CB_ERR && len > 0 )
+
+    wxCHECK_MSG( len != CB_ERR, str, wxS("Invalid index") );
+
+    if ( len > 0 )
     {
         if ( ::SendMessage
                (