Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Initialize wxButton::m_authNeeded in ctor and not Create() in wxMSW.

Browse Source 
Ensure that the member is always initialized as calling GetAuthNeeded() for a
default-constructed button would access a non-initialized variable before.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@67058 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin
2011-02-27 12:47:43 +00:00
parent 6af59fe7f4
commit 98977bf454
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
include/wx/msw/button.h
View File

@@ -100,6 +100,7 @@ private:
void Init() void Init()
{ {
m_imageData = NULL; m_imageData = NULL;
m_authNeeded = false;
} }
// Switches button into owner-drawn mode: this is used if we need to draw // Switches button into owner-drawn mode: this is used if we need to draw

2
src/msw/button.cpp
View File

@@ -450,8 +450,6 @@ bool wxButton::Create(wxWindow *parent,
const wxValidator& validator, const wxValidator& validator,
const wxString& name) const wxString& name)
{ {
m_authNeeded = false;
wxString label(lbl); wxString label(lbl);
if (label.empty() && wxIsStockID(id)) if (label.empty() && wxIsStockID(id))
{ {