From 97f58c1603000afe045c7ab56962e8a75966f7c2 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Thu, 28 Nov 2013 13:47:00 +0000 Subject: [PATCH] Fix wxCommandProcessor::IsDirty() for unsaved unmodified case. IsDirty() still returned true even after undoing all the commands which was wrong, as there was nothing to save in this case. Closes #15722. git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@75310 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/common/cmdproc.cpp | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/common/cmdproc.cpp b/src/common/cmdproc.cpp index 54f14ea028..4534de633e 100644 --- a/src/common/cmdproc.cpp +++ b/src/common/cmdproc.cpp @@ -329,16 +329,11 @@ void wxCommandProcessor::ClearCommands() bool wxCommandProcessor::IsDirty() const { - if ( m_commands.empty() ) - { - // If we have never been modified, we can't be dirty. - return false; - } - if ( !m_lastSavedCommand ) { - // If we have been modified but have never been saved, we're dirty. - return true; + // We have never been saved, so we are dirty if and only if we have any + // commands at all. + return m_currentCommand; } if ( !m_currentCommand )