document that CanRead() and GetImageCount() functions of wxImageHandlers do NOT modify the current stream position and that they require seekable streams; rename current GetImageCount() functions to DoGetImageCount() and put save-and-restore stream position logic in GetImageCount(); add comments in the various DoCanRead() and in DoGetImageCount() where the stream position is modified; remove unneeded SeekI(0) calls from DoCanRead() and DoGetImageCount() functions: they didn't allow to load images from non-seekable streams; implement forward-seeking in wxInputStream::SeekI() also for non-seekable streams
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@60852 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
@@ -98,7 +98,10 @@ public:
|
||||
// constructor, destructor, etc.
|
||||
wxIFFDecoder(wxInputStream *s);
|
||||
~wxIFFDecoder() { Destroy(); }
|
||||
|
||||
// NOTE: this function modifies the current stream position
|
||||
bool CanRead();
|
||||
|
||||
int ReadIFF();
|
||||
bool ConvertToImage(wxImage *image) const;
|
||||
};
|
||||
@@ -234,9 +237,6 @@ bool wxIFFDecoder::CanRead()
|
||||
if ( !m_f->Read(buf, WXSIZEOF(buf)) )
|
||||
return false;
|
||||
|
||||
if ( m_f->SeekI(-(wxFileOffset)WXSIZEOF(buf), wxFromCurrent) == wxInvalidOffset )
|
||||
return false;
|
||||
|
||||
return (memcmp(buf, "FORM", 4) == 0) && (memcmp(buf+8, "ILBM", 4) == 0);
|
||||
}
|
||||
|
||||
@@ -787,6 +787,7 @@ bool wxIFFHandler::DoCanRead(wxInputStream& stream)
|
||||
wxIFFDecoder decod(&stream);
|
||||
|
||||
return decod.CanRead();
|
||||
// it's ok to modify the stream position here
|
||||
}
|
||||
|
||||
#endif // wxUSE_STREAMS
|
||||
|
||||
Reference in New Issue
Block a user