final prototype fixes (done using ifacecheck)

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@52753 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

interface/accel.h

@@ -195,7 +195,7 @@ public:
         Destroys the wxAcceleratorTable object.
         See @ref overview_refcount_destruct for more info.
     */
-    ~wxAcceleratorTable();
+    virtual ~wxAcceleratorTable();
 
     /**
         Returns @true if the accelerator table is valid.

interface/animate.h

@@ -98,7 +98,7 @@ public:
                 const wxPoint& pos = wxDefaultPosition,
                 const wxSize& size = wxDefaultSize,
                 long style = wxAC_DEFAULT_STYLE,
-                const wxString& name = "animationctrl");
+                const wxString& name = wxAnimationCtrlNameStr);
 
     /**
         Returns the animation associated with this control.
@@ -156,7 +156,7 @@ public:
         Note that the inactive bitmap, if smaller than the control's size, will be
         centered in the control; if bigger, it will be stretched to fit it.
     */
-    void SetInactiveBitmap(const wxBitmap& bmp);
+    virtual void SetInactiveBitmap(const wxBitmap& bmp);
 
     /**
         Stops playing the animation.
@@ -207,7 +207,7 @@ public:
         Destructor.
         See @ref overview_refcount_destruct for more info.
     */
-    ~wxAnimation();
+    virtual ~wxAnimation();
 
     /**
         Returns the delay for the i-th frame in milliseconds.

interface/app.h

@@ -225,10 +225,11 @@ public:
             the message specified as argument to wxASSERT_MSG or wxFAIL_MSG, will
             be @NULL if just wxASSERT or wxFAIL was used
     */
-    virtual void OnAssertFailure(const wxChar file, int line,
-                                 const wxChar func,
-                                 const wxChar cond,
-                                 const wxChar msg);
+    virtual void OnAssertFailure(const wxChar *file,
+                                 int line,
+                                 const wxChar *func,
+                                 const wxChar *cond,
+                                 const wxChar *msg);
 
     /**
         Called when command line parsing fails (i.e. an incorrect command line option
@@ -537,7 +538,7 @@ public:
         If this function returns @false and you need to attract users attention to
         the application, you may use wxTopLevelWindow::RequestUserAttention to do it.
     */
-    bool IsActive() const;
+    virtual bool IsActive() const;
 
     /**
         Windows-only function for processing a message. This function is called
@@ -573,7 +574,7 @@ public:
 
         @see wxIdleEvent
     */
-    bool SendIdleEvents(wxWindow* win, wxIdleEvent& event);
+    virtual bool SendIdleEvents(wxWindow* win, wxIdleEvent& event);
 
     /**
         Allows the programmer to specify whether the application will exit when the

interface/apptrait.h

@@ -78,6 +78,11 @@ public:
         Returns the wxStandardPaths object for the application.
         It's normally the same for wxBase and wxGUI except in the case of wxMac
         and wxCocoa.
+
+        @todo the real function returns a reference to wxStandardPathsBase;
+              user looking at these docs will write code:
+                    wxStandardPaths &ref = ...->GetStandardPaths();
+              which won't compile...
     */
     virtual wxStandardPaths& GetStandardPaths();
 
@@ -93,8 +98,7 @@ public:
         and put in given pointers the versions of the GTK library in use.
         See wxPlatformInfo for more details.
     */
-    virtual wxPortId GetToolkitVersion(int* major = NULL,
-                                       int* minor = NULL);
+    virtual wxPortId GetToolkitVersion(int* major = NULL, int* minor = NULL) const;
 
     /**
         Returns @true if @c fprintf(stderr) goes somewhere, @false otherwise.
@@ -105,7 +109,7 @@ public:
         Returns @true if the library was built as wxUniversal.
         Always returns @false for wxBase-only apps.
     */
-    bool IsUsingUniversalWidgets() const;
+    virtual bool IsUsingUniversalWidgets() const;
 
     /**
         Shows the assert dialog with the specified message in GUI mode or just prints

interface/archive.h

@@ -34,7 +34,7 @@ public:
         Closes the current entry. On a non-seekable stream reads to the end of
         the current entry first.
     */
-    bool CloseEntry();
+    virtual bool CloseEntry();
 
     /**
         Closes the current entry if one is open, then reads the meta-data for
@@ -50,7 +50,7 @@ public:
         @a entry must be from the same archive file that this wxArchiveInputStream
         is reading, and it must be reading it from a seekable stream.
     */
-    bool OpenEntry(wxArchiveEntry& entry);
+    virtual bool OpenEntry(wxArchiveEntry& entry);
 };
 
 
@@ -77,7 +77,7 @@ public:
     /**
         Calls Close() if it has not already been called.
     */
-    ~wxArchiveOutputStream();
+    virtual ~wxArchiveOutputStream();
 
     /**
         Closes the archive, returning @true if it was successfully written.

interface/arrstr.h

@@ -135,8 +135,7 @@ public:
         This function uses linear search for wxArrayString.
         Returns index of the first item matched or @c wxNOT_FOUND if there is no match.
     */
-    int Index(const wxString& sz, bool bCase = true,
-              bool bFromEnd = false);
+    int Index(const wxString& sz, bool bCase = true, bool bFromEnd = false) const;
 
     /**
         Insert the given number of @a copies of the new element in the array before the
@@ -156,23 +155,23 @@ public:
         Returns @true if the array is empty, @false otherwise. This function returns the
         same result as @e GetCount() == 0 but is probably easier to read.
     */
-    bool IsEmpty();
+    bool IsEmpty() const;
 
     /**
-        Return the array element at position @e nIndex. An assert failure will
+        Return the array element at position @a nIndex. An assert failure will
         result from an attempt to access an element beyond the end of array in debug
         mode, but no check is done in release mode.
 
         @see operator[] for the operator version.
     */
-    wxString Item(size_t nIndex) const;
+    wxString& Item(size_t nIndex) const;
 
     /**
         Returns the last element of the array. Attempt to access the last element of
         an empty array will result in assert failure in debug build, however no checks
         are done in release mode.
     */
-    wxString Last();
+    wxString& Last() const;
 
     /**
         Removes the first item matching this value. An assert failure is provoked by
@@ -243,7 +242,7 @@ public:
     /**
         Assignment operator.
     */
-    wxArrayString operator =(const wxArrayString& array);
+    wxArrayString& operator=(const wxArrayString&);
 
     /**
         Compares 2 arrays respecting the case. Returns @true only if the arrays have
@@ -252,13 +251,13 @@ public:
     bool operator ==(const wxArrayString& array) const;
 
     /**
-        Return the array element at position @e nIndex. An assert failure will
+        Return the array element at position @a nIndex. An assert failure will
         result from an attempt to access an element beyond the end of array in
         debug mode, but no check is done in release mode.
 
         This is the operator version of the Item() method.
     */
-    wxString operator[](size_t nIndex);
+    wxString& operator[](size_t nIndex) const;
 };
 
 

interface/artprov.h

@@ -161,7 +161,7 @@ public:
         The destructor automatically removes the provider from the provider stack used
         by GetBitmap().
     */
-    ~wxArtProvider();
+    virtual ~wxArtProvider();
 
     /**
         Derived art provider classes must override this method to create requested art

interface/aui/aui.h

@@ -128,7 +128,7 @@ public:
     /**
         Dtor.
     */
-    ~wxAuiManager();
+    virtual ~wxAuiManager();
 
     //@{
     /**