OnExit() is called for modules which were initialized even if the init of

the subsequent modules fails


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@1422 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

include/wx/module.h

@@ -18,32 +18,41 @@
 
 #include "wx/object.h"
 #include "wx/list.h"
-#include "wx/setup.h"
 
+// declare a linked list of modules
+class wxModule;
+WX_DECLARE_LIST(wxModule, wxModuleList);
+
+// declaring a class derived from wxModule will automatically create an
+// instance of this class on program startup, call its OnInit() method and call
+// OnExit() on program termination (but only if OnInit() succeeded)
 class WXDLLEXPORT wxModule : public wxObject
 {
 public:
-    wxModule(void) {}
-    ~wxModule(void) {}
+    wxModule() {}
+    virtual ~wxModule() {}
 
-    // If returns FALSE, quits the application immediately.
-    bool Init(void) { return OnInit(); }
-    void Exit(void) { OnExit(); }
+    // if module init routine returns FALSE application will fail to startup
+    bool Init() { return OnInit(); }
+    void Exit() { OnExit(); }
 
     // Override both of these
-    virtual bool OnInit(void) = 0;
-    virtual void OnExit(void) = 0;
+        // called on program startup
+    virtual bool OnInit() = 0;
+        // called just before program termination, but only if OnInit()
+        // succeeded
+    virtual void OnExit() = 0;
 
     static void RegisterModule(wxModule* module);
-    static bool RegisterModules(void);
-    static bool InitializeModules(void);
-    static void CleanUpModules(void);
+    static void RegisterModules();
+    static bool InitializeModules();
+    static void CleanUpModules();
 
 protected:
-    static wxList   m_modules;
+    static wxModuleList m_modules;
 
     DECLARE_CLASS(wxModule)
 };
 
-#endif
+#endif // _WX_MODULEH__
 

src/common/module.cpp

@@ -22,10 +22,13 @@
 
 #include "wx/module.h"
 #include "wx/hash.h"
+#include "wx/listimpl.cpp"
+
+WX_DEFINE_LIST(wxModuleList);
 
 IMPLEMENT_CLASS(wxModule, wxObject)
 
-wxList wxModule::m_modules;
+wxModuleList wxModule::m_modules;
 
 void wxModule::RegisterModule(wxModule* module)
 {
@@ -34,7 +37,7 @@ void wxModule::RegisterModule(wxModule* module)
 
 // Collect up all module-derived classes, create an instance of each,
 // and register them.
-bool wxModule::RegisterModules(void)
+void wxModule::RegisterModules()
 {
     wxNode *node;
     wxClassInfo* classInfo;
@@ -44,36 +47,48 @@ bool wxModule::RegisterModules(void)
     while (node)
     {
         classInfo = (wxClassInfo *)node->Data();
-        if ((classInfo != (& (wxModule::sm_classwxModule))) &&
-            classInfo->IsKindOf(CLASSINFO(wxModule)))
+        if ( classInfo->IsKindOf(CLASSINFO(wxModule)) &&
+            (classInfo != (& (wxModule::sm_classwxModule))) )
         {
             wxModule* module = (wxModule *)classInfo->CreateObject();
             RegisterModule(module);
         }
         node = wxClassInfo::sm_classTable->Next();
     }
-    return TRUE;
 }
 
-bool wxModule::InitializeModules(void)
+bool wxModule::InitializeModules()
 {
     // Initialize user-defined modules
-    for (wxNode *node = m_modules.First(); node; node = node->Next())
+    wxModuleList::Node *node;
+    for ( node = m_modules.GetFirst(); node; node = node->GetNext() )
     {
-      if (!((wxModule*)(node->Data()))->Init())
+        if ( !node->GetData()->Init() )
+        {
+            // clean up already initialized modules - process in reverse order
+            wxModuleList::Node *n;
+            for ( n = node->GetPrevious(); n; n = n->GetPrevious() )
+            {
+                n->GetData()->OnExit();
+            }
+
             return FALSE;
         }
+    }
+
     return TRUE;
 }
 
-void wxModule::CleanUpModules(void)
+void wxModule::CleanUpModules()
 {
     // Cleanup user-defined modules
-    for(wxNode* node = m_modules.Last(); node; node = node->Previous())
+    wxModuleList::Node *node;
+    for ( node = m_modules.GetFirst(); node; node = node->GetNext() )
     {
-      ((wxModule*)(node->Data()))->Exit();
-      delete (wxModule*)(node->Data());
+        node->GetData()->Exit();
     }
+
+    m_modules.DeleteContents(TRUE);
     m_modules.Clear();
 }