Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Test using wrong credentials in the auth unit tests too

Browse Source 
In addition to verifying that the correct password works, check that
using a wrong one does not.
This commit is contained in:
Vadim Zeitlin
2021-01-10 00:41:05 +01:00
parent b64ad7f06d
commit 8820bb9609
1 changed files with 32 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
tests/net/webrequest.cpp
View File

@@ -197,10 +197,22 @@ TEST_CASE_METHOD(RequestFixture, "WebRequest", "[net][webrequest]")
Create("/basic-auth/wxtest/wxwidgets"); Create("/basic-auth/wxtest/wxwidgets");
Run(wxWebRequest::State_Unauthorized, 401); Run(wxWebRequest::State_Unauthorized, 401);
REQUIRE( request.GetAuthChallenge().IsOk() ); REQUIRE( request.GetAuthChallenge().IsOk() );
request.GetAuthChallenge().SetCredentials("wxtest", "wxwidgets");
loop.Run(); SECTION("Good password")
REQUIRE( request.GetResponse().GetStatus() == 200 ); {
REQUIRE( request.GetState() == wxWebRequest::State_Completed ); request.GetAuthChallenge().SetCredentials("wxtest", "wxwidgets");
loop.Run();
CHECK( request.GetResponse().GetStatus() == 200 );
CHECK( request.GetState() == wxWebRequest::State_Completed );
}
SECTION("Bad password")
{
request.GetAuthChallenge().SetCredentials("wxtest", "foobar");
loop.Run();
CHECK( request.GetResponse().GetStatus() == 401 );
CHECK( request.GetState() == wxWebRequest::State_Unauthorized );
}
} }
SECTION("Server auth DIGEST") SECTION("Server auth DIGEST")
@@ -214,10 +226,22 @@ TEST_CASE_METHOD(RequestFixture, "WebRequest", "[net][webrequest]")
Create("/digest-auth/auth/wxtest/wxwidgets"); Create("/digest-auth/auth/wxtest/wxwidgets");
Run(wxWebRequest::State_Unauthorized, 401); Run(wxWebRequest::State_Unauthorized, 401);
REQUIRE( request.GetAuthChallenge().IsOk() ); REQUIRE( request.GetAuthChallenge().IsOk() );
request.GetAuthChallenge().SetCredentials("wxtest", "wxwidgets");
loop.Run(); SECTION("Good password")
REQUIRE( request.GetResponse().GetStatus() == 200 ); {
REQUIRE( request.GetState() == wxWebRequest::State_Completed ); request.GetAuthChallenge().SetCredentials("wxtest", "wxwidgets");
loop.Run();
CHECK( request.GetResponse().GetStatus() == 200 );
CHECK( request.GetState() == wxWebRequest::State_Completed );
}
SECTION("Bad password")
{
request.GetAuthChallenge().SetCredentials("foo", "bar");
loop.Run();
CHECK( request.GetResponse().GetStatus() == 401 );
CHECK( request.GetState() == wxWebRequest::State_Unauthorized );
}
} }
} }