Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix recently introduced crash in MSW wxTaskbarButton::New()

Browse Source 
Fixed regression introduced in f7458dd03f ("Use
wxComPtr<> instead of raw pointers in wxTaskbarButton code", see #16557).

Closes https://github.com/wxWidgets/wxWidgets/pull/96
This commit is contained in:
Tobias Taschner
2015-09-19 17:51:56 +02:00
committed by Vadim Zeitlin
parent 7e6836e9f5
commit 870a545345
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/msw/taskbarbutton.cpp
View File

@@ -698,7 +698,7 @@ bool wxThumbBarButton::UpdateParentTaskBarButton()
/* static */ /* static */
wxTaskBarButton* wxTaskBarButton::New(wxWindow* parent) wxTaskBarButton* wxTaskBarButton::New(wxWindow* parent)
{ {
wxCOMPtr<wxITaskbarList3> taskbarList; wxITaskbarList3* taskbarList = NULL;
HRESULT hr = CoCreateInstance HRESULT hr = CoCreateInstance
( (
@@ -720,6 +720,7 @@ wxTaskBarButton* wxTaskBarButton::New(wxWindow* parent)
// This is however unexpected. // This is however unexpected.
wxLogApiError(wxT("ITaskbarList3::Init"), hr); wxLogApiError(wxT("ITaskbarList3::Init"), hr);
taskbarList->Release();
return NULL; return NULL;
} }