From 852f817291f8c80b249c55f19ecf23ef544c187e Mon Sep 17 00:00:00 2001 From: ali kettab Date: Sat, 25 Jul 2020 12:34:25 +0100 Subject: [PATCH] Get rid of redundant call to wxDELETE (no real change) --- tests/controls/checkboxtest.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/controls/checkboxtest.cpp b/tests/controls/checkboxtest.cpp index e1edd3e514..04709b7635 100644 --- a/tests/controls/checkboxtest.cpp +++ b/tests/controls/checkboxtest.cpp @@ -53,6 +53,7 @@ private: // any meaning otherwise. bool CreateCheckBox(long style) { + wxDELETE( m_check ); m_check = new wxCheckBox(wxTheApp->GetTopWindow(), wxID_ANY, "Check box", wxDefaultPosition, wxDefaultSize, style); return false; @@ -110,7 +111,6 @@ void CheckBoxTestCase::Check() #ifdef wxHAS_3STATE_CHECKBOX void CheckBoxTestCase::ThirdState() { - wxDELETE(m_check); CreateCheckBox(wxCHK_3STATE); CPPUNIT_ASSERT_EQUAL(wxCHK_UNCHECKED, m_check->Get3StateValue()); @@ -128,7 +128,6 @@ void CheckBoxTestCase::ThirdState() void CheckBoxTestCase::ThirdStateUser() { - wxDELETE(m_check); CreateCheckBox(wxCHK_3STATE | wxCHK_ALLOW_3RD_STATE_FOR_USER); CPPUNIT_ASSERT_EQUAL(wxCHK_UNCHECKED, m_check->Get3StateValue()); @@ -147,14 +146,12 @@ void CheckBoxTestCase::ThirdStateUser() void CheckBoxTestCase::InvalidStyles() { // Check that using incompatible styles doesn't work. - wxDELETE( m_check ); WX_ASSERT_FAILS_WITH_ASSERT( CreateCheckBox(wxCHK_2STATE | wxCHK_3STATE) ); #if !wxDEBUG_LEVEL CPPUNIT_ASSERT( !m_check->Is3State() ); CPPUNIT_ASSERT( !m_check->Is3rdStateAllowedForUser() ); #endif - wxDELETE( m_check ); WX_ASSERT_FAILS_WITH_ASSERT( CreateCheckBox(wxCHK_2STATE | wxCHK_ALLOW_3RD_STATE_FOR_USER) ); #if !wxDEBUG_LEVEL @@ -163,7 +160,6 @@ void CheckBoxTestCase::InvalidStyles() #endif // wxCHK_ALLOW_3RD_STATE_FOR_USER without wxCHK_3STATE doesn't work. - wxDELETE( m_check ); WX_ASSERT_FAILS_WITH_ASSERT( CreateCheckBox(wxCHK_ALLOW_3RD_STATE_FOR_USER) ); }