Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix coordinates adjustment for wxGenericListCtrl mouse events

Browse Source 
wxListHeaderWindow event coordinates don't need to be adjusted, as it's
positioned at (0, 0) of its parent window anyhow, but wxListMainWindow
events do need to be adjusted to use the parent window coordinates, as
it's the only window that should be seen by the outside code -- and also
for consistency with the native MSW version.

This corrects the changes originally done in
651d7a1ff8

See #18133.
This commit is contained in:
Vadim Zeitlin
2018-05-17 03:42:17 +02:00
parent 57f620e7e1
commit 8401d3fec9
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/generic/listctrl.cpp
View File

@@ -1366,13 +1366,6 @@ bool wxListHeaderWindow::SendListEvent(wxEventType type, const wxPoint& pos)
wxListEvent le( type, parent->GetId() );
le.SetEventObject( parent );
le.m_pointDrag = pos;
// the position should be relative to the parent window, not
// this one for compatibility with MSW and common sense: the
// user code doesn't know anything at all about this header
// window, so why should it get positions relative to it?
le.m_pointDrag.y -= GetSize().y;
le.m_col = m_column;
return !parent->GetEventHandler()->ProcessEvent( le ) || le.IsAllowed();
}
@@ -2220,7 +2213,13 @@ void wxListMainWindow::SendNotify( size_t line,
// set only for events which have position
if ( point != wxDefaultPosition )
le.m_pointDrag = point;
{
// the position should be relative to the parent window, not
// this one for compatibility with MSW and common sense: the
// user code doesn't know anything at all about this window,
// so why should it get positions relative to it?
le.m_pointDrag = GetPosition() + point;
}
// don't try to get the line info for virtual list controls: the main
// program has it anyhow and if we did it would result in accessing all