Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix wxTextCtrl contents corruption with long strings in wxMSW.

Browse Source 
wxMSW automatically extended wxTextCtrl length limit beyond the tiny standard
32KB when it was exceeded, but part of the text being appended into the
control was lost when doing it.

Fix this by retrying insertion after extending the limit.

Closes #15980.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@75940 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin
2014-02-20 00:32:34 +00:00
parent 43f960c9e1
commit 81b62354dc
2 changed files with 85 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
tests/controls/textctrltest.cpp
View File

@@ -85,6 +85,7 @@ private:
CPPUNIT_TEST( FontStyle );
CPPUNIT_TEST( Lines );
CPPUNIT_TEST( LogTextCtrl );
CPPUNIT_TEST( LongText );
CPPUNIT_TEST( PositionToCoords );
CPPUNIT_TEST( PositionToCoordsRich );
CPPUNIT_TEST( PositionToCoordsRich2 );
@@ -106,6 +107,7 @@ private:
void FontStyle();
void Lines();
void LogTextCtrl();
void LongText();
void PositionToCoords();
void PositionToCoordsRich();
void PositionToCoordsRich2();
@@ -521,6 +523,36 @@ void TextCtrlTestCase::LogTextCtrl()
CPPUNIT_ASSERT(!m_text->IsEmpty());
}
void TextCtrlTestCase::LongText()
{
delete m_text;
CreateText(wxTE_MULTILINE|wxTE_DONTWRAP);
// Pattern for the line.
wxChar linePattern[100+1];
for (int i = 0; i < WXSIZEOF(linePattern) - 1; i++)
{
linePattern[i] = wxChar('0' + i % 10);
}
linePattern[WXSIZEOF(linePattern) - 1] = wxChar('\0');
// Fill the control.
const int numLines = 1000;
m_text->SetMaxLength(15000);
for (int i = 0; i < numLines; i++)
{
m_text->AppendText(wxString::Format(wxT("[%3d] %s\n"), i, linePattern));
}
// Check the content.
for (int i = 0; i < numLines; i++)
{
wxString pattern = wxString::Format(wxT("[%3d] %s"), i, linePattern);
wxString line = m_text->GetLineText(i);
CPPUNIT_ASSERT_EQUAL( line, pattern );
}
}
void TextCtrlTestCase::PositionToCoords()
{
DoPositionToCoordsTestWithStyle(0);