Reverting wxAppTraits GSocket patch

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@25253 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

include/wx/apptrait.h

@@ -29,9 +29,6 @@ extern "C"
     struct GSocketGUIFunctionsTable;
 }
 
-// FIXME: Eventually unify Mac OS 9
-class GSocketBSD;
-
 // ----------------------------------------------------------------------------
 // toolkit information
 // ----------------------------------------------------------------------------
@@ -116,10 +113,6 @@ public:
 #if wxUSE_SOCKETS
     // return table of GUI callbacks for GSocket code or NULL in wxBase
     virtual GSocketGUIFunctionsTable* GetSocketGUIFunctionsTable() = 0;
-
-    // return a new GSocket with the EventLoop_* stuff implemented.
-    // or at least stubbed (i.e. wxBase)
-    virtual GSocketBSD* CreateGSocket() = 0;
 #endif
 
 
@@ -175,7 +168,6 @@ public:
     virtual wxRendererNative *CreateRenderer();
 #if wxUSE_SOCKETS
     virtual GSocketGUIFunctionsTable* GetSocketGUIFunctionsTable();
-    virtual GSocketBSD* CreateGSocket();
 #endif
 
 #ifdef __WXDEBUG__
@@ -206,9 +198,6 @@ public:
     virtual wxRendererNative *CreateRenderer();
 #if wxUSE_SOCKETS
     virtual GSocketGUIFunctionsTable* GetSocketGUIFunctionsTable();
-    // return a new GSocket with the EventLoop_* stuff implemented.
-    // TODO: Remove this because each GUI should implement it separately
-    virtual GSocketBSD* CreateGSocket();
 #endif
 
 #ifdef __WXDEBUG__

src/common/appbase.cpp

@@ -53,10 +53,6 @@
     #include "wx/fontmap.h"
 #endif // wxUSE_FONTMAP
 
-#if wxUSE_SOCKETS
-    #include "wx/gsocket.h"
-#endif // wxUSE_SOCKETS
-
 #if defined(__WXMAC__)
     // VZ: MacTypes.h is enough under Mac OS X (where I could test it) but
     //     I don't know which headers are needed under earlier systems so
@@ -479,16 +475,6 @@ GSocketGUIFunctionsTable* wxConsoleAppTraitsBase::GetSocketGUIFunctionsTable()
 {
     return NULL;
 }
-
-// TODO: Use a different class that only stubs out the event loop functions
-GSocketBSD* wxConsoleAppTraitsBase::CreateGSocket()
-{
-#ifdef wxUSE_GSOCKET_CPLUSPLUS
-    return new GSocketBSDGUIShim();
-#else
-    return NULL;
-#endif
-}
 #endif
 
 // ----------------------------------------------------------------------------

src/common/appcmn.cpp

@@ -605,14 +605,5 @@ GSocketGUIFunctionsTable* wxGUIAppTraitsBase::GetSocketGUIFunctionsTable()
 #endif // !__WXMAC__ || __DARWIN__
 }
 
-GSocketBSD* wxGUIAppTraitsBase::CreateGSocket()
-{
-#ifdef wxUSE_GSOCKET_CPLUSPLUS
-    return new GSocketBSDGUIShim();
-#else
-    return NULL;
-#endif
-}
-
 #endif
 

src/unix/gsocket.cpp

@@ -1404,7 +1404,7 @@ void GSocketBSD::Detected_Write()
 /* Compatibility functions for GSocket */
 GSocket *GSocket_new(void)
 {
-    GSocket *newsocket = wxTheApp->GetTraits()->CreateGSocket();
+    GSocket *newsocket = new GSocketBSDGUIShim();
     if(newsocket->IsOk())
         return newsocket;
     delete newsocket;