Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix deleting of wxTextCtrl in wxNumValidator test case

Browse Source 
This was broken in da973c3caf (Get rid of CppUnit boilerplate in numeric
validator unit tests, 2021-02-21) which replaced DestroyChildren() in
the old CppUnit test case dtor with just "delete m_text", as this didn't
take care of "text2" created in one of the tests.

Using DestroyChildren() still seems overly side, so ensure that "text2"
is destroyed explicitly.
This commit is contained in:
Vadim Zeitlin
2021-02-22 14:26:23 +01:00
parent bdaca38904
commit 72a24b402b
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/validators/valnum.cpp
View File

@@ -20,6 +20,8 @@
#include "asserthelper.h" #include "asserthelper.h"
#include "testableframe.h" #include "testableframe.h"
#include "wx/scopeguard.h"
#include "wx/uiaction.h" #include "wx/uiaction.h"
class NumValidatorTestCase class NumValidatorTestCase
@@ -243,6 +245,7 @@ TEST_CASE_METHOD(NumValidatorTestCase, "ValNum::Interactive", "[valnum]")
// Create a sibling text control to be able to switch focus and thus // Create a sibling text control to be able to switch focus and thus
// trigger the control validation/normalization. // trigger the control validation/normalization.
wxTextCtrl * const text2 = new wxTextCtrl(m_text->GetParent(), wxID_ANY); wxTextCtrl * const text2 = new wxTextCtrl(m_text->GetParent(), wxID_ANY);
wxON_BLOCK_EXIT_OBJ0( *text2, wxWindow::Destroy );
text2->Move(10, 80); // Just to see it better while debugging... text2->Move(10, 80); // Just to see it better while debugging...
wxFloatingPointValidator<float> valFloat(3); wxFloatingPointValidator<float> valFloat(3);
valFloat.SetRange(-10., 10.); valFloat.SetRange(-10., 10.);