From 769cb2e205eb7a6b777867530c5dd9412d72e5d4 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 27 Jun 2021 13:16:08 +0200 Subject: [PATCH 01/14] Add workflow for cross-building wxMSW on GitHub Actions Use MinGW to build and Wine to run the GUI tests. --- .github/workflows/ci.yml | 2 + .github/workflows/ci_msw_cross.yml | 193 +++++++++++++++++++++++++++++ 2 files changed, 195 insertions(+) create mode 100644 .github/workflows/ci_msw_cross.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 85b42a2128..cab1461ca1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -6,6 +6,7 @@ on: branches: - master paths-ignore: + - '.github/workflows/ci_msw_cross.yml' - 'build/tools/appveyor*.bat' - 'build/tools/travis-ci.sh' - 'distrib/**' @@ -22,6 +23,7 @@ on: branches: - master paths-ignore: + - '.github/workflows/ci_msw_cross.yml' - 'build/tools/appveyor*.bat' - 'build/tools/travis-ci.sh' - 'distrib/**' diff --git a/.github/workflows/ci_msw_cross.yml b/.github/workflows/ci_msw_cross.yml new file mode 100644 index 0000000000..55c404229a --- /dev/null +++ b/.github/workflows/ci_msw_cross.yml @@ -0,0 +1,193 @@ +# CI workflow cross-building wxMSW under Linux. +name: wxMSW cross-build + +on: + push: + branches: + - master + paths-ignore: + - '.github/workflows/ci.yml' + - 'build/tools/appveyor*.bat' + - 'build/tools/travis-ci.sh' + - 'distrib/**' + - 'docs/**' + - 'interface/**' + - 'include/msvc/**' + - 'include/wx/gtk/**' + - 'include/wx/osx/**' + - 'locale/**' + - 'src/msw/**' + - 'src/osx/**' + - '*.md' + - '*.yml' + - 'wxwidgets.props' + pull_request: + branches: + - master + paths-ignore: + - '.github/workflows/ci.yml' + - 'build/tools/appveyor*.bat' + - 'build/tools/travis-ci.sh' + - 'distrib/**' + - 'docs/**' + - 'interface/**' + - 'include/msvc/**' + - 'include/wx/gtk/**' + - 'include/wx/osx/**' + - 'locale/**' + - 'src/msw/**' + - 'src/osx/**' + - '*.md' + - '*.yml' + - 'wxwidgets.props' + +jobs: + msw-cross-build: + # Set up this job to run in a Debian Sid container because it has recent + # versions of MinGW and Wine and is simpler to test with locally than the + # bespoke container used by GitHub Actions by default. + runs-on: ubuntu-latest + container: debian:sid-slim + name: ${{ matrix.name }} + strategy: + fail-fast: false + matrix: + include: + - name: wxMSW 64 bits + - name: wxMSW 32 bits + triplet: i686-w64-mingw32 + env: + # Default to 64-bit build. + HOST_TRIPLET: ${{ matrix.triplet || 'x86_64-w64-mingw32' }} + + # Run all commands as the normal user, created by the first step below. + # + # Note that the Bash options used here are the same as for the default + # shell used by GitHub Actions to minimize any surprises. + defaults: + run: + shell: /usr/bin/setpriv --reuid=runner --regid=adm --clear-groups --inh-caps=-all bash --noprofile --norc -eo pipefail {0} + + steps: + - name: Set up container user + # Specify the default shell explicitly to override the default value above. + shell: bash + run: | + apt-get -q -o=Dpkg::Use-Pty=0 update + apt-get -qq install sudo + + # Create a user with the same UID/GID and name as the existing user + # outside of the container and allow it using sudo without password. + useradd --home-dir $HOME --no-create-home --gid adm --uid 1001 runner + + echo 'runner ALL=(ALL) NOPASSWD:ALL' > /etc/sudoers.d/runner + + - name: Install prerequisites + run: | + export DEBIAN_FRONTEND=noninteractive + + packages="git make wine x11-xserver-utils xvfb" + + case "${HOST_TRIPLET}" in + x86_64-w64-mingw32) + packages="$packages g++-mingw-w64-x86-64 wine64" + ;; + + i686-w64-mingw32) + sudo dpkg --add-architecture i386 + sudo apt-get -q -o=Dpkg::Use-Pty=0 update + packages="$packages g++-mingw-w64-i686 wine32" + ;; + + *) + echo "Unknown host triplet \"${HOST_TRIPLET}\"." + exit 1 + ;; + esac + + sudo apt-get -qq install $packages + + - name: Checkout + uses: actions/checkout@v2 + with: + submodules: 'recursive' + + - name: Set environment variables + run: | + echo "WINEPATH=$(winepath --windows $(pwd)/lib)" >> $GITHUB_ENV + + cpu_count=`nproc` + ((cpu_count++)) + echo "wxMAKE_ARGS=-k -j$cpu_count" >> $GITHUB_ENV + + echo "wxMAKEFILE_ERROR_CXXFLAGS=-Werror -Wno-error=cpp" >> $GITHUB_ENV + + - name: Configure + run: | + ./configure --host=${HOST_TRIPLET} --disable-sys-libs --disable-optimise --disable-debug_info || rc=$? + + if [ -n "$rc" ]; then + echo '*** Configuring failed, contents of config.log follows: ***' + echo '-----------------------------------------------------------' + cat config.log + echo '-----------------------------------------------------------' + exit $rc + fi + + - name: Build + run: | + make $wxMAKE_ARGS "CXXFLAGS=$wxMAKEFILE_ERROR_CXXFLAGS" + + - name: Build samples + run: | + make $wxMAKE_ARGS "CXXFLAGS=$wxMAKEFILE_ERROR_CXXFLAGS" samples + + - name: Build tests + working-directory: tests + run: | + make $wxMAKE_ARGS failtest + make $wxMAKE_ARGS "CXXFLAGS=$wxMAKEFILE_ERROR_CXXFLAGS" + + - name: Run non-GUI tests + working-directory: tests + run: | + . ../build/tools/httpbin.sh + + httpbin_launch + + wine ./test || rc=$? + + if [ -n "$rc" ]; then + httpbin_show_log + exit $rc + fi + + - name: Run GUI tests + working-directory: tests + run: | + echo 'Launching Xvfb...' + sudo mkdir /tmp/.X11-unix + sudo chmod 1777 /tmp/.X11-unix + Xvfb :10 -screen 0 1600x1200x24 & + num_tries=1 + while true; do + if xset -d :10 -q >/dev/null 2>&1; then + echo 'Xvfb has become available.' + # Trying to use it immediately can still result in errors + # when creating the windows, somehow, so give it some time + # to settle. + sleep 3 + break + fi + + if [[ $num_tries -gt 10 ]]; then + echo 'Timed out waiting for Xvfb' + exit 1 + fi + + ((num_tries++)) + echo "Still waiting for Xvfb (attempt #$num_tries)" + sleep 3 + done + echo 'Launching the GUI test:' + DISPLAY=:10 wine ./test_gui From 3e5cf7a5c7f7b67e02493255db6354f45ac5249c Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 27 Jun 2021 13:42:00 +0200 Subject: [PATCH 02/14] Fix owner after checkout --- .github/workflows/ci_msw_cross.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci_msw_cross.yml b/.github/workflows/ci_msw_cross.yml index 55c404229a..ba99b14dac 100644 --- a/.github/workflows/ci_msw_cross.yml +++ b/.github/workflows/ci_msw_cross.yml @@ -112,8 +112,14 @@ jobs: with: submodules: 'recursive' - - name: Set environment variables + - name: System and environment setup run: | + normal_uid=`id --user` + + # The checkout actions runs as root and there doesn't seem to be any + # way to change this, so just adjust the owner after checkout. + sudo chown -R $normal_uid $GITHUB_WORKSPACE + echo "WINEPATH=$(winepath --windows $(pwd)/lib)" >> $GITHUB_ENV cpu_count=`nproc` From 7d796c6aa6fcbbafb927673b9afff622fb09ce98 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 27 Jun 2021 14:21:28 +0200 Subject: [PATCH 03/14] Install python3 and pip for httpbin We need Python 3 for running httpbin for wxWebRequest tests. --- .github/workflows/ci_msw_cross.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci_msw_cross.yml b/.github/workflows/ci_msw_cross.yml index ba99b14dac..c7020474fd 100644 --- a/.github/workflows/ci_msw_cross.yml +++ b/.github/workflows/ci_msw_cross.yml @@ -86,7 +86,7 @@ jobs: run: | export DEBIAN_FRONTEND=noninteractive - packages="git make wine x11-xserver-utils xvfb" + packages="git make python3 python3-pip wine x11-xserver-utils xvfb" case "${HOST_TRIPLET}" in x86_64-w64-mingw32) From b9fb8358b35431d9f1560b018d3a3b42fb698924 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 27 Jun 2021 14:34:49 +0200 Subject: [PATCH 04/14] Add the directory containing MinGW DLLs to Wine PATH too These DLLs are required for running any applications built using MinGW. --- .github/workflows/ci_msw_cross.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci_msw_cross.yml b/.github/workflows/ci_msw_cross.yml index c7020474fd..537f4ba257 100644 --- a/.github/workflows/ci_msw_cross.yml +++ b/.github/workflows/ci_msw_cross.yml @@ -120,7 +120,10 @@ jobs: # way to change this, so just adjust the owner after checkout. sudo chown -R $normal_uid $GITHUB_WORKSPACE - echo "WINEPATH=$(winepath --windows $(pwd)/lib)" >> $GITHUB_ENV + # Add the directories containing MinGW and wx DLLs to Wine path. + winepath="$(winepath --windows /usr/lib/gcc/${HOST_TRIPLET}/$(${HOST_TRIPLET}-gcc -dumpversion|tr -d '\r'))" + winepath="${winepath};$(winepath --windows $(pwd)/lib)" + echo "WINEPATH=${winepath}" >> $GITHUB_ENV cpu_count=`nproc` ((cpu_count++)) From 0bb6f80a1e11da0fc208018e2b1eba06762d8886 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 27 Jun 2021 15:07:23 +0200 Subject: [PATCH 05/14] Check that lsb_release is available before using it It is not present in e.g. sid-slim image used for wxMSW cross-build CI workflow. --- build/tools/httpbin.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/build/tools/httpbin.sh b/build/tools/httpbin.sh index 4243e8b497..c627b09d12 100644 --- a/build/tools/httpbin.sh +++ b/build/tools/httpbin.sh @@ -16,7 +16,9 @@ httpbin_launch() { case "$(uname -s)" in Linux) - dist_codename=$(lsb_release --codename --short) + if command -v lsb_release > /dev/null; then + dist_codename=$(lsb_release --codename --short) + fi ;; Darwin) From 0eca5b6846fdf5667e6bce5374186c1c1040df0f Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 27 Jun 2021 17:30:15 +0200 Subject: [PATCH 06/14] Use wine64 for running 64 bit MSW binaries Add WINERUN envirionment variable containing the right command to use. --- .github/workflows/ci_msw_cross.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci_msw_cross.yml b/.github/workflows/ci_msw_cross.yml index 537f4ba257..f96e898680 100644 --- a/.github/workflows/ci_msw_cross.yml +++ b/.github/workflows/ci_msw_cross.yml @@ -91,12 +91,14 @@ jobs: case "${HOST_TRIPLET}" in x86_64-w64-mingw32) packages="$packages g++-mingw-w64-x86-64 wine64" + winerun=wine64 ;; i686-w64-mingw32) sudo dpkg --add-architecture i386 sudo apt-get -q -o=Dpkg::Use-Pty=0 update packages="$packages g++-mingw-w64-i686 wine32" + winerun=wine ;; *) @@ -107,6 +109,8 @@ jobs: sudo apt-get -qq install $packages + echo "WINERUN=${winerun}" >> $GITHUB_ENV + - name: Checkout uses: actions/checkout@v2 with: @@ -164,7 +168,7 @@ jobs: httpbin_launch - wine ./test || rc=$? + $WINERUN ./test || rc=$? if [ -n "$rc" ]; then httpbin_show_log @@ -199,4 +203,4 @@ jobs: sleep 3 done echo 'Launching the GUI test:' - DISPLAY=:10 wine ./test_gui + DISPLAY=:10 $WINERUN ./test_gui From 938a0dd9196e71deb583fb3d93cb1a4fc971d59f Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 27 Jun 2021 18:42:37 +0100 Subject: [PATCH 07/14] Slightly improve check for pip in httpbin script Using "-m pip" results in an unwanted usage message from pip, so use "-c 'import pip'" instead. --- build/tools/httpbin.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build/tools/httpbin.sh b/build/tools/httpbin.sh index c627b09d12..7b9f4df273 100644 --- a/build/tools/httpbin.sh +++ b/build/tools/httpbin.sh @@ -44,7 +44,7 @@ httpbin_launch() { esac # Ensure that we have at least some version of pip. - if ! python3 -m pip; then + if ! python3 -c 'import pip'; then sudo apt-get -q -o=Dpkg::Use-Pty=0 install python3-pip fi From 3c714de200e2159e94d953e9b73316317eacb9b0 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 27 Jun 2021 18:46:29 +0100 Subject: [PATCH 08/14] Launch Xvfb before running non-GUI tests in GitHub wxMSW workflow We must be able to create windows even in non-GUI tests for the windows used internally, e.g. the one created during wxSocket initialization, so ensure Xvfb is running before the tests start. --- .github/workflows/ci_msw_cross.yml | 40 ++++++++++++++++-------------- 1 file changed, 22 insertions(+), 18 deletions(-) diff --git a/.github/workflows/ci_msw_cross.yml b/.github/workflows/ci_msw_cross.yml index f96e898680..e7843e0079 100644 --- a/.github/workflows/ci_msw_cross.yml +++ b/.github/workflows/ci_msw_cross.yml @@ -161,22 +161,7 @@ jobs: make $wxMAKE_ARGS failtest make $wxMAKE_ARGS "CXXFLAGS=$wxMAKEFILE_ERROR_CXXFLAGS" - - name: Run non-GUI tests - working-directory: tests - run: | - . ../build/tools/httpbin.sh - - httpbin_launch - - $WINERUN ./test || rc=$? - - if [ -n "$rc" ]; then - httpbin_show_log - exit $rc - fi - - - name: Run GUI tests - working-directory: tests + - name: Launch Xvfb run: | echo 'Launching Xvfb...' sudo mkdir /tmp/.X11-unix @@ -202,5 +187,24 @@ jobs: echo "Still waiting for Xvfb (attempt #$num_tries)" sleep 3 done - echo 'Launching the GUI test:' - DISPLAY=:10 $WINERUN ./test_gui + echo 'Xvfb is running on display :10' + echo 'DISPLAY=:10' >> $GITHUB_ENV + + - name: Run non-GUI tests + working-directory: tests + run: | + . ../build/tools/httpbin.sh + + httpbin_launch + + $WINERUN ./test || rc=$? + + if [ -n "$rc" ]; then + httpbin_show_log + exit $rc + fi + + - name: Run GUI tests + working-directory: tests + run: | + $WINERUN ./test_gui From 3808e6a28dd10871fa677d3bbfe779d0b59f7903 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Mon, 28 Jun 2021 00:56:17 +0100 Subject: [PATCH 09/14] Install winbind package required for using wxWebRequest with Wine This should address 009a:err:winediag:SECUR32_initNTLMSP ntlm_auth was not found or is outdated. Make sure that ntlm_auth >= 3.0.25 is in your path. Usually, you can find it in the winbind package of your distribution. Wine error and the subsequent test failures. --- .github/workflows/ci_msw_cross.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci_msw_cross.yml b/.github/workflows/ci_msw_cross.yml index e7843e0079..f680211709 100644 --- a/.github/workflows/ci_msw_cross.yml +++ b/.github/workflows/ci_msw_cross.yml @@ -86,7 +86,7 @@ jobs: run: | export DEBIAN_FRONTEND=noninteractive - packages="git make python3 python3-pip wine x11-xserver-utils xvfb" + packages="git make python3 python3-pip winbind wine x11-xserver-utils xvfb" case "${HOST_TRIPLET}" in x86_64-w64-mingw32) From 1051d9f0dacfbdceafa6ca1261e81b99f3a66a3a Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Mon, 28 Jun 2021 01:02:47 +0100 Subject: [PATCH 10/14] Rename WINERUN environment variable to wxTEST_RUNNER Make the variable name wx-specific before starting to use it in wx tests too. --- .github/workflows/ci_msw_cross.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci_msw_cross.yml b/.github/workflows/ci_msw_cross.yml index f680211709..26c8bf9d17 100644 --- a/.github/workflows/ci_msw_cross.yml +++ b/.github/workflows/ci_msw_cross.yml @@ -109,7 +109,7 @@ jobs: sudo apt-get -qq install $packages - echo "WINERUN=${winerun}" >> $GITHUB_ENV + echo "wxTEST_RUNNER=${winerun}" >> $GITHUB_ENV - name: Checkout uses: actions/checkout@v2 @@ -197,7 +197,7 @@ jobs: httpbin_launch - $WINERUN ./test || rc=$? + $wxTEST_RUNNER ./test || rc=$? if [ -n "$rc" ]; then httpbin_show_log @@ -207,4 +207,4 @@ jobs: - name: Run GUI tests working-directory: tests run: | - $WINERUN ./test_gui + $wxTEST_RUNNER ./test_gui From 2be8f78982755794586d7640c702018feb6897aa Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Mon, 28 Jun 2021 01:05:03 +0100 Subject: [PATCH 11/14] Make wxExecute() unit test work when using Wine too Use wxTEST_RUNNER in this test, which can be/is set to "wine" by the GitHub wxMSW CI workflow and can also be set manually if necessary, to make executing MSW commands under non-MSW systems have a chance to actually work (but note that the tests still fail when run under Wine). --- tests/exec/exec.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/exec/exec.cpp b/tests/exec/exec.cpp index 5afe329d4d..69b7eb3c17 100644 --- a/tests/exec/exec.cpp +++ b/tests/exec/exec.cpp @@ -116,7 +116,13 @@ private: wxProcess* callback_ = NULL) { forceExitLoop = forceExitLoop_; - command = command_; + + // Prepend the command with the value of wxTEST_RUNNER if it's + // defined to make this test work when using Wine too. + if ( wxGetEnv("wxTEST_RUNNER", &command) ) + command += ' '; + command += command_; + flags = flags_; callback = callback_; From 2ac55105516f3313c178a0a1cd7ff822066bd652 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Mon, 28 Jun 2021 01:18:17 +0100 Subject: [PATCH 12/14] Skip running currently failing tests under Wine Ideally these failures ought to be debugged and fixed, but this is not really critical as the tests pass under native MSW systems, so it seems like the failures are due to problems in Wine rather than with the tests themselves, so for now simply skip the failing tests to let the entire build pass. --- .github/workflows/ci_msw_cross.yml | 50 ++++++++++++++++++++++++++++-- 1 file changed, 48 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci_msw_cross.yml b/.github/workflows/ci_msw_cross.yml index 26c8bf9d17..4831f1a1ef 100644 --- a/.github/workflows/ci_msw_cross.yml +++ b/.github/workflows/ci_msw_cross.yml @@ -197,7 +197,29 @@ jobs: httpbin_launch - $wxTEST_RUNNER ./test || rc=$? + # Some tests are currently failing under Wine while they pass under + # native MSW, just skip running them until they can be dealt with. + + # As soon as we specify the tests to exclude explicitly, we also need + # to exclude the tests that are not run by default, so start with this. + excluded_tests=('~[.]') + + # Only TestSetTimes fails, but only the full test can be excluded. + excluded_tests+=('~FileNameTestCase') + + # Only FileError fails, but the whole test has to be excluded. + excluded_tests+=('~FileFunctionsTestCase') + + # Sporadic failures due to extra events. + excluded_tests+=('~wxFileSystemWatcher::EventCreate') + + # The test fails (even with wxTEST_RUNNER-related changes) and hangs. + excluded_tests+=('~ExecTestCase') + + # Wine WinHTTP implementations seems buggy, there are many errors. + excluded_tests+=('~[webrequest]') + + $wxTEST_RUNNER ./test "${excluded_tests[@]}" || rc=$? if [ -n "$rc" ]; then httpbin_show_log @@ -207,4 +229,28 @@ jobs: - name: Run GUI tests working-directory: tests run: | - $wxTEST_RUNNER ./test_gui + # Same as for the non-GUI test above, except many more GUI tests fail + # under Wine. + excluded_gui_tests=('~[.]') + + excluded_gui_tests+=('~BitmapComboBoxTestCase') # TextChangeEvents + excluded_gui_tests+=('~ClippingBoxTestCase*') + excluded_gui_tests+=('~ComboBoxTestCase') # TextChangeEvents + excluded_gui_tests+=('~DatePickerCtrlTestCase') # Range + excluded_gui_tests+=('~wxDC::GetTextExtent') + excluded_gui_tests+=('~ExecTestCase') + excluded_gui_tests+=('~wxFont::GetSet') + excluded_gui_tests+=('~GraphicsPathTestCaseGDIPlus') + excluded_gui_tests+=('~ImageList*') + excluded_gui_tests+=('~RadioButton::Focus') + excluded_gui_tests+=('~SettingsTestCase') # GetFont fails + excluded_gui_tests+=('~SliderTestCase') # Thumb + excluded_gui_tests+=('~TransformMatrixTestCase*') + excluded_gui_tests+=('~TreeCtrlTestCase') # LabelEdit + excluded_gui_tests+=('~TextCtrlTestCase') # many sub-tests + excluded_gui_tests+=('~wxTextCtrl::InitialCanUndo') + excluded_gui_tests+=('~[wxWebView]') + excluded_gui_tests+=('~Window::PositioningBeyondShortLimit') + excluded_gui_tests+=('~XRC::LoadURL') + + $wxTEST_RUNNER ./test_gui "${excluded_gui_tests[@]}" From e28b2d91fc0e1e0f1085aaac9cd8cc78527b3f00 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sat, 3 Jul 2021 16:11:19 +0200 Subject: [PATCH 13/14] Revert commits trying to fix wxWebRequest tests under Wine This reverts commits 7d796c6aa6 (Install python3 and pip for httpbin, 2021-06-27) and 3808e6a28d (Install winbind package required for using wxWebRequest with Wine, 2021-06-28) as we skip wxWebRequest tests anyhow under Wine because they don't work with its WinHTTP implementation, so running httpbin is not necessary any longer and so neither is installing Python. These commits are still preserved in history and this commit itself could be reverted later if Wine WinHTTP becomes functional enough to run wxWebRequest tests successfully. --- .github/workflows/ci_msw_cross.yml | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci_msw_cross.yml b/.github/workflows/ci_msw_cross.yml index 4831f1a1ef..2122000bbd 100644 --- a/.github/workflows/ci_msw_cross.yml +++ b/.github/workflows/ci_msw_cross.yml @@ -86,7 +86,7 @@ jobs: run: | export DEBIAN_FRONTEND=noninteractive - packages="git make python3 python3-pip winbind wine x11-xserver-utils xvfb" + packages="git make wine x11-xserver-utils xvfb" case "${HOST_TRIPLET}" in x86_64-w64-mingw32) @@ -193,10 +193,6 @@ jobs: - name: Run non-GUI tests working-directory: tests run: | - . ../build/tools/httpbin.sh - - httpbin_launch - # Some tests are currently failing under Wine while they pass under # native MSW, just skip running them until they can be dealt with. @@ -219,12 +215,7 @@ jobs: # Wine WinHTTP implementations seems buggy, there are many errors. excluded_tests+=('~[webrequest]') - $wxTEST_RUNNER ./test "${excluded_tests[@]}" || rc=$? - - if [ -n "$rc" ]; then - httpbin_show_log - exit $rc - fi + $wxTEST_RUNNER ./test "${excluded_tests[@]}" - name: Run GUI tests working-directory: tests From 7d9d4c9e50b23876d81384551939801661bf66c0 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sat, 3 Jul 2021 17:57:43 +0200 Subject: [PATCH 14/14] Rename GitHub Unix CI workflow No real changes, just use a less generic name now that we have wxMSW cross-building CI workflow too. --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cab1461ca1..e906677e57 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1,5 +1,5 @@ -# Continuous integration workflow for wxWidgets. -name: GitHub CI +# CI workflow for wxWidgets builds using configure+make under Unix. +name: Unix builds on: push: