Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make wxWebSessionFactory private

Browse Source 
Having wxWebSessionFactory part of the public API implies keeping
compatibility with the possible ways of implementing it which is too
restrictive for no good reason, so move this class to the private header
and don't document it nor wxWebSession::RegisterFactory() (which is now
private).
This commit is contained in:
Vadim Zeitlin
2020-12-27 00:40:16 +01:00
parent e5bd5a926c
commit 71d5729171
7 changed files with 37 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
include/wx/webrequest.h
View File

@@ -26,6 +26,7 @@
class wxWebResponse;
class wxWebSession;
class wxWebSessionFactory;
class wxWebAuthChallenge;
WX_DECLARE_STRING_HASH_MAP(wxString, wxWebRequestHeaderMap);
@@ -195,14 +196,6 @@ private:
wxDECLARE_NO_COPY_CLASS(wxWebAuthChallenge);
};
class WXDLLIMPEXP_NET wxWebSessionFactory
{
public:
virtual wxWebSession* Create() = 0;
virtual ~wxWebSessionFactory() { }
};
extern WXDLLIMPEXP_DATA_NET(const char) wxWebSessionBackendDefault[];
extern WXDLLIMPEXP_DATA_NET(const char) wxWebSessionBackendWinHTTP[];
extern WXDLLIMPEXP_DATA_NET(const char) wxWebSessionBackendURLSession[];
@@ -228,9 +221,6 @@ public:
static wxWebSession* New(const wxString& backend = wxWebSessionBackendDefault);
static void RegisterFactory(const wxString& backend,
const wxSharedPtr<wxWebSessionFactory>& factory);
static bool IsBackendAvailable(const wxString& backend);
protected:
@@ -239,6 +229,9 @@ protected:
const wxWebRequestHeaderMap& GetHeaders() const { return m_headers; }
private:
static void RegisterFactory(const wxString& backend,
const wxSharedPtr<wxWebSessionFactory>& factory);
// Make it a friend to allow accessing our m_headers.
friend class wxWebRequest;