Don't rely on argv being NULL-terminated under MSW

Since the changes of c9a458bfe8 ("Use Win32
::CommandLineToArgvW() to tokenize command line"), this is not guaranteed any
more as this Win32 function doesn't necessarily ensure it under older MSW
versions such as XP.

Just use "argc" explicitly instead of relying on this in wxCmdLineArgsArray to
fix crashing under XP.

include/wx/cmdargs.h

@@ -31,19 +31,17 @@ public:
     wxCmdLineArgsArray() { m_argsA = NULL; m_argsW = NULL; }
 
     template <typename T>
-    wxCmdLineArgsArray& operator=(T **argv)
+    void Init(int argc, T **argv)
     {
         FreeArgs();
 
         m_args.clear();
+        m_args.reserve(argc);
 
-        if ( argv )
+        for ( int i = 0; i < argc; i++ )
         {
-            while ( *argv )
+            m_args.push_back(argv[i]);
-                m_args.push_back(*argv++);
         }
-
-        return *this;
     }
 
     operator char**() const

src/common/init.cpp

@@ -335,8 +335,7 @@ bool wxEntryStart(int& argc, wxChar **argv)
 
     // remember, possibly modified (e.g. due to removal of toolkit-specific
     // parameters), command line arguments in member variables
-    app->argc = argc;
+    app->argv.Init(argc, argv);
-    app->argv = argv;
 
     wxCallAppCleanup callAppCleanup(app.get());
 

src/gtk/app.cpp

@@ -396,7 +396,7 @@ bool wxApp::Initialize(int& argc_, wxChar **argv_)
 
     // update internal arg[cv] as GTK+ may have removed processed options:
     this->argc = argc_;
-    this->argv = argv_;
+    this->argv.Init(argc_, argv_);
 
     if ( m_traits )
     {