From 6cc415390f8b41e9507fda00fd284e1885eca31c Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Wed, 16 Jul 2008 01:54:58 +0000 Subject: [PATCH] backport fixes for the fix for transparency in static bitmaps (r51824) from trunk (r54651 and r54652) git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/branches/WX_2_8_BRANCH@54653 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775 --- src/msw/statbmp.cpp | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/src/msw/statbmp.cpp b/src/msw/statbmp.cpp index 3a7e5f80b4..38afea6f7e 100644 --- a/src/msw/statbmp.cpp +++ b/src/msw/statbmp.cpp @@ -29,6 +29,7 @@ #include "wx/statbmp.h" #ifndef WX_PRECOMP + #include "wx/app.h" #include "wx/window.h" #include "wx/icon.h" #include "wx/dcclient.h" @@ -169,12 +170,14 @@ bool wxStaticBitmap::Create(wxWindow *parent, // GetBestSize will work properly now, so set the best size if needed SetInitialSize(size); - // Win9x and 2000 don't draw correctly the images with alpha channel so we - // need to draw them ourselves and it's easier to just always do it rather - // than check if we have an image with alpha or not - if ( wxGetWinVersion() <= wxWinVersion_2000 ) + // Windows versions before XP (and even XP if the application has no + // manifest and so the old comctl32.dll is used) don't draw correctly the + // images with alpha channel so we need to draw them ourselves and it's + // easier to just always do it rather than check if we have an image with + // alpha or not + if ( wxTheApp->GetComCtl32Version() < 600 ) { - Connect(wxEVT_PAINT, wxPaintEventHandler(wxStaticBitmap::DoPaintManually)); + Connect(wxEVT_PAINT, wxPaintEventHandler(wxStaticBitmap::DoPaintManually)); } return true; @@ -261,8 +264,11 @@ void wxStaticBitmap::DoPaintManually(wxPaintEvent& WXUNUSED(event)) const wxSize size(GetSize()); const wxBitmap bmp(GetBitmap()); - // Clear the background - dc.SetBrush(GetBackgroundColour()); + // Clear the background: notice that we're supposed to be transparent, so + // use the parent background colour if we don't have our own instead of + // falling back to the default + const wxWindow *win = UseBgCol() ? this : GetParent(); + dc.SetBrush(win->GetBackgroundColour()); dc.SetPen(*wxTRANSPARENT_PEN); dc.DrawRectangle(0, 0, size.GetWidth(), size.GetHeight());