diff --git a/src/common/socket.cpp b/src/common/socket.cpp index c0c35df4e2..64803df7a4 100644 --- a/src/common/socket.cpp +++ b/src/common/socket.cpp @@ -980,7 +980,11 @@ wxUint32 wxSocketBase::DoRead(void* buffer_, wxUint32 nbytes) { // if we don't want to wait, just return immediately if ( m_flags & wxSOCKET_NOWAIT ) + { + // this shouldn't be counted as an error in this case + SetError(wxSOCKET_NOERROR); break; + } // otherwise wait until the socket becomes ready for reading or // an error occurs on it diff --git a/tests/image/image.cpp b/tests/image/image.cpp index 0616c08bd2..644cc6c745 100644 --- a/tests/image/image.cpp +++ b/tests/image/image.cpp @@ -110,15 +110,6 @@ void ImageTestCase::LoadFromFile() void ImageTestCase::LoadFromSocketStream() { - // Skip this test when running on a build slave because it just keeps - // failing erratically and sends build failure notifications when it does. - // - // Of course, it would be even better to understand why does it fail but so - // far we didn't manage to do it so disable until someone can find the - // problem. - if ( wxGetUserId().Lower().Matches("buildslave*") ) - return; - if (!IsNetworkAvailable()) // implemented in test.cpp { wxLogWarning("No network connectivity; skipping the " @@ -131,24 +122,37 @@ void ImageTestCase::LoadFromSocketStream() wxBitmapType type; } testData[] = { - { "http://wxwidgets.org/logo9.jpg", wxBITMAP_TYPE_JPEG }, - { "http://wxwidgets.org/favicon.ico", wxBITMAP_TYPE_ICO } + { "http://www.wxwidgets.org/logo9.jpg", wxBITMAP_TYPE_JPEG }, + { "http://www.wxwidgets.org/favicon.ico", wxBITMAP_TYPE_ICO } }; for (unsigned int i=0; iIsOk()); + WX_ASSERT_MESSAGE + ( + ("Opening URL \"%s\" failed.", testData[i].url), + in_stream && in_stream->IsOk() + ); wxImage img; // NOTE: it's important to inform wxImage about the type of the image being // loaded otherwise it will try to autodetect the format, but that // requires a seekable stream! - CPPUNIT_ASSERT(img.LoadFile(*in_stream, testData[i].type)); + WX_ASSERT_MESSAGE + ( + ("Loading image from \"%s\" failed.", testData[i].url), + img.LoadFile(*in_stream, testData[i].type) + ); delete in_stream; }