Refactor: use wxBookCtrlBase::m_selection in all derived classes.
All book control classes with the exception of wxGTK wxNotebook stored the currently selected page in m_selection or m_nSelection (or, in wxUniv wxNotebook case, m_sel) variable. Remove all of them and add m_selection directly to the base class itself so that it can be reused everywhere. Closes #12622. git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@65931 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
@@ -107,7 +107,7 @@ static void gtk_notebook_page_change_callback(GtkNotebook *WXUNUSED(widget),
|
||||
// make wxNotebook::GetSelection() return the correct (i.e. consistent
|
||||
// with wxBookCtrlEvent::GetSelection()) value even though the page is
|
||||
// not really changed in GTK+
|
||||
notebook->m_selection = page;
|
||||
notebook->SetSelection(page);
|
||||
}
|
||||
else
|
||||
{
|
||||
@@ -121,7 +121,7 @@ static void gtk_notebook_page_change_callback(GtkNotebook *WXUNUSED(widget),
|
||||
// make wxNotebook::GetSelection() return the correct (i.e. consistent
|
||||
// with wxBookCtrlEvent::GetSelection()) value even though the page is
|
||||
// not really changed in GTK+
|
||||
notebook->m_selection = page;
|
||||
notebook->SetSelection(page);
|
||||
|
||||
notebook->SendPageChangedEvent(old);
|
||||
}
|
||||
@@ -292,7 +292,6 @@ void wxNotebook::Init()
|
||||
m_inSwitchPage = false;
|
||||
|
||||
m_imageList = NULL;
|
||||
m_selection = -1;
|
||||
m_themeEnabled = true;
|
||||
}
|
||||
|
||||
@@ -375,8 +374,8 @@ int wxNotebook::GetSelection() const
|
||||
gpointer cur = notebook->cur_page;
|
||||
if ( cur != NULL )
|
||||
{
|
||||
wxConstCast(this, wxNotebook)->m_selection =
|
||||
g_list_index( nb_pages, cur );
|
||||
const_cast<wxNotebook *>(this)->
|
||||
SetSelection(g_list_index( nb_pages, cur ));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user