From 6644a489e8a6b03979239ac77a89c4c6d1a7f0a6 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sun, 22 Oct 2017 18:04:50 +0200 Subject: [PATCH] Test that RunScript() returns false in case of errors Testing only for successful return is insufficient, we also need to check that errors are detected. --- tests/controls/webtest.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/controls/webtest.cpp b/tests/controls/webtest.cpp index eeecb2ec08..31322f383f 100644 --- a/tests/controls/webtest.cpp +++ b/tests/controls/webtest.cpp @@ -366,6 +366,11 @@ void WebTestCase::RunScript() var tzoffset = d.getTimezoneOffset() * 60000; return new Date(d.getTime() - tzoffset);}f();", &result)); CPPUNIT_ASSERT_EQUAL("\"2016-10-08T21:30:40.000Z\"", result); + + // Check for errors too. + CPPUNIT_ASSERT(!m_browser->RunScript("syntax(error")); + CPPUNIT_ASSERT(!m_browser->RunScript("syntax(error", &result)); + CPPUNIT_ASSERT(!m_browser->RunScript("x.y.z")); } void WebTestCase::SetPage()