Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid too many sash position changed events when splitter is resized.

Browse Source 
We could call SetSashPositionAndNotify() twice in a row which was probably
unexpected and possibly wasteful, if the user code did anything non trivial in
response to this event.

Just call it once after we're certain which sash position do we want to set.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@69601 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin
2011-10-30 19:48:50 +00:00
parent 1b5dfa53aa
commit 6460ce5afe
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/generic/splitter.cpp
View File

@@ -451,20 +451,23 @@ void wxSplitterWindow::OnSize(wxSizeEvent& event)
// Don't do anything if the size didn't really change.
if ( size != old_size )
{
int newPosition = -1;
// Apply gravity if we use it.
int delta = (int) ( (size - old_size)*m_sashGravity );
if ( delta != 0 )
{
int newPosition = m_sashPosition + delta;
newPosition = m_sashPosition + delta;
if( newPosition < m_minimumPaneSize )
newPosition = m_minimumPaneSize;
SetSashPositionAndNotify(newPosition);
}
// Also check if the second window became too small.
int adjustedPosition = AdjustSashPosition(m_sashPosition);
if ( adjustedPosition != m_sashPosition )
SetSashPositionAndNotify(adjustedPosition);
newPosition = AdjustSashPosition(newPosition == -1
? m_sashPosition
: newPosition);
if ( newPosition != m_sashPosition )
SetSashPositionAndNotify(newPosition);
}
}