diff --git a/include/wx/fs_inet.h b/include/wx/fs_inet.h index 16ef297579..6299089ef2 100644 --- a/include/wx/fs_inet.h +++ b/include/wx/fs_inet.h @@ -6,18 +6,6 @@ // Licence: wxWindows Licence ///////////////////////////////////////////////////////////////////////////// -/* - -REMARKS : - -This FS creates local cache (in /tmp directory). The cache is freed -on program exit. - -Size of cache is limited to cca 1000 items (due to GetTempFileName -limitation) - - -*/ #ifndef _WX_FS_INET_H_ #define _WX_FS_INET_H_ diff --git a/src/common/fs_inet.cpp b/src/common/fs_inet.cpp index 5304925002..2aa70a14e4 100644 --- a/src/common/fs_inet.cpp +++ b/src/common/fs_inet.cpp @@ -6,19 +6,6 @@ // Licence: wxWindows Licence ///////////////////////////////////////////////////////////////////////////// -/* - -REMARKS : - -This FS creates local cache (in /tmp directory). The cache is freed -on program exit. - -Size of cache is limited to cca 1000 items (due to GetTempFileName -limitation) - - -*/ - #ifdef __GNUG__ #pragma implementation "fs_inet.h" #endif @@ -45,26 +32,37 @@ limitation) #include "wx/fs_inet.h" #include "wx/module.h" -class wxInetCacheNode : public wxObject -{ - private: - wxString m_Temp; - wxString m_Mime; +// ---------------------------------------------------------------------------- +// Helper classes +// ---------------------------------------------------------------------------- - public: - wxInetCacheNode(const wxString& l, const wxString& m) : wxObject() {m_Temp = l; m_Mime = m;} - const wxString& GetTemp() const {return m_Temp;} - const wxString& GetMime() const {return m_Mime;} +// This stream deletes the file when destroyed +class wxTemporaryFileInputStream : public wxFileInputStream +{ +public: + wxTemporaryFileInputStream(const wxString& filename) : + wxFileInputStream(filename), m_filename(filename) {} + + ~wxTemporaryFileInputStream() + { + // NB: copied from wxFileInputStream dtor, we need to do it before + // wxRemoveFile + if (m_file_destroy) + { + delete m_file; + m_file_destroy = false; + } + wxRemoveFile(m_filename); + } + +protected: + wxString m_filename; }; - - - -//-------------------------------------------------------------------------------- +// ---------------------------------------------------------------------------- // wxInternetFSHandler -//-------------------------------------------------------------------------------- - +// ---------------------------------------------------------------------------- static wxString StripProtocolAnchor(const wxString& location) { @@ -84,7 +82,6 @@ static wxString StripProtocolAnchor(const wxString& location) } - bool wxInternetFSHandler::CanOpen(const wxString& location) { wxString p = GetProtocol(location); @@ -100,69 +97,44 @@ bool wxInternetFSHandler::CanOpen(const wxString& location) wxFSFile* wxInternetFSHandler::OpenFile(wxFileSystem& WXUNUSED(fs), const wxString& location) { - wxString right = GetProtocol(location) + wxT(":") + StripProtocolAnchor(location); - wxInputStream *s; - wxString content; - wxInetCacheNode *info; + wxString right = + GetProtocol(location) + wxT(":") + StripProtocolAnchor(location); - info = (wxInetCacheNode*) m_Cache.Get(right); - - // Add item into cache: - if (info == NULL) + wxURL url(right); + if (url.GetError() == wxURL_NOERR) { - wxURL url(right); - if (url.GetError() == wxURL_NOERR) + wxInputStream *s = url.GetInputStream(); + wxString content = url.GetProtocol().GetContentType(); + if (content == wxEmptyString) content = GetMimeTypeFromExt(location); + if (s) { - s = url.GetInputStream(); - content = url.GetProtocol().GetContentType(); - if (content == wxEmptyString) content = GetMimeTypeFromExt(location); - if (s) - { - wxChar buf[256]; + wxString tmpfile = + wxFileName::CreateTempFileName(wxT("wxhtml")); - wxGetTempFileName( wxT("wxhtml"), buf); - info = new wxInetCacheNode(buf, content); - m_Cache.Put(right, info); - - { // ok, now copy it: - wxFileOutputStream sout((wxString)buf); - s -> Read(sout); // copy the stream - } - delete s; + { // now copy streams content to temporary file: + wxFileOutputStream sout(tmpfile); + s->Read(sout); } - else - return (wxFSFile*) NULL; // we can't open the URL + delete s; + + return new wxFSFile(new wxTemporaryFileInputStream(tmpfile), + right, + content, + GetAnchor(location) +#if wxUSE_DATETIME + , wxDateTime::Now() +#endif // wxUSE_DATETIME + ); } - else - return (wxFSFile*) NULL; // incorrect URL } - // Load item from cache: - s = new wxFileInputStream(info->GetTemp()); - if (!s) - return (wxFSFile*) NULL; - - return new wxFSFile(s, - right, - info->GetMime(), - GetAnchor(location), - wxDateTime::Now()); + return (wxFSFile*) NULL; // incorrect URL } wxInternetFSHandler::~wxInternetFSHandler() { - wxNode *n; - wxInetCacheNode *n2; - - m_Cache.BeginFind(); - while ((n = m_Cache.Next()) != NULL) - { - n2 = (wxInetCacheNode*) n->GetData(); - wxRemoveFile(n2->GetTemp()); - delete n2; - } } class wxFileSystemInternetModule : public wxModule