Check for self-assignment in operator=

2019-02-25 00:48:41 -08:00
parent 90ecc401c0
commit 60fb8f93cb
2 changed files with 12 additions and 7 deletions
--- a/src/qt/region.cpp
+++ b/src/qt/region.cpp
@@ -351,10 +351,12 @@ wxRegionIterator::~wxRegionIterator()

 wxRegionIterator& wxRegionIterator::operator=(const wxRegionIterator& ri)
 {
-    delete m_qtRects;
-
-    m_qtRects = new QVector< QRect >( *ri.m_qtRects );
-    m_pos = ri.m_pos;
+    if (this != &ri)
+    {
+        delete m_qtRects;
+        m_qtRects = new QVector< QRect >( *ri.m_qtRects );
+        m_pos = ri.m_pos;
+    }
    return *this;
 }