diff --git a/docs/changes.txt b/docs/changes.txt index ac16a6d1c9..6d21154315 100644 --- a/docs/changes.txt +++ b/docs/changes.txt @@ -99,6 +99,8 @@ All (GUI): - Fixed wxHTML's pagebreaks computation in tables (D.J.Stauffer). - Fixed wxRichTextCtrl input that uses Alt on Mac OS X, for example Polish Pro input. +- Fixed wxHtmlWindow::SelectionToText() to correctly insert newlines after + single-cell paragraphs. All (Unix): diff --git a/src/html/htmlwin.cpp b/src/html/htmlwin.cpp index f72a8a9733..4635f95429 100644 --- a/src/html/htmlwin.cpp +++ b/src/html/htmlwin.cpp @@ -881,21 +881,27 @@ wxString wxHtmlWindow::DoSelectionToText(wxHtmlSelection *sel) return wxEmptyString; wxClientDC dc(this); - - const wxHtmlCell *end = sel->GetToCell(); wxString text; - wxHtmlTerminalCellsInterator i(sel->GetFromCell(), end); - if ( i ) - { - text << i->ConvertToText(sel); - ++i; - } - const wxHtmlCell *prev = *i; + + wxHtmlTerminalCellsInterator i(sel->GetFromCell(), sel->GetToCell()); + const wxHtmlCell *prev = NULL; + while ( i ) { - if ( prev->GetParent() != i->GetParent() ) - text << _T('\n'); - text << i->ConvertToText(*i == end ? sel : NULL); + // When converting HTML content to plain text, the entire paragraph + // (container in wxHTML) goes on single line. A new paragraph (that + // should go on its own line) has its own container. Therefore, the + // simplest way of detecting where to insert newlines in plain text + // is to check if the parent container changed -- if it did, we moved + // to a new paragraph. + if ( prev && prev->GetParent() != i->GetParent() ) + text << wxT('\n'); + + // NB: we don't need to pass the selection to ConvertToText() in the + // middle of the selected text; it's only useful when only part of + // a cell is selected + text << i->ConvertToText(sel); + prev = *i; ++i; }