Detect attempts to catch wxEVT_TEXT_ENTER without wxTE_PROCESS_ENTER
This is never going to work, so complain about trying to do it to help with catching this bug. This is possible thanks to the new OnDynamicBind() method invoked whenever a dynamic event handler is bound to a control, so this doesn't detect all possible occurrences of the bug (such as specifying the handler in a static event table or in a validator), but it's still better than nothing. In the future OnDynamicBind() should be extended for other invalid calls, e.g. binding a handler for wxEVT_TEXT_ENTER to a non-text control shouldn't work neither, ideally.
This commit is contained in:
@@ -1693,6 +1693,13 @@ void wxEvtHandler::DoBind(int id,
|
||||
wxDynamicEventTableEntry *entry =
|
||||
new wxDynamicEventTableEntry(eventType, id, lastId, func, userData);
|
||||
|
||||
// Check if the derived class allows binding such event handlers.
|
||||
if ( !OnDynamicBind(*entry) )
|
||||
{
|
||||
delete entry;
|
||||
return;
|
||||
}
|
||||
|
||||
if (!m_dynamicEvents)
|
||||
m_dynamicEvents = new DynamicEvents;
|
||||
|
||||
|
Reference in New Issue
Block a user