wxProcess() fixes: will really call parent's event handler and will pass the

exited process status now


git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@1637 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775

include/wx/process.h

@@ -20,39 +20,48 @@
 #include "wx/object.h"
 #include "wx/event.h"
 
+// Process Event handling
+class WXDLLEXPORT wxProcessEvent : public wxEvent
+{
+DECLARE_DYNAMIC_CLASS(wxProcessEvent)
+
+public:
+    wxProcessEvent(int id = 0, int pid = 0, int exitcode = 0) : wxEvent(id)
+    {
+        m_eventType = wxEVT_END_PROCESS;
+        m_pid = pid;
+        m_exitcode = exitcode;
+    }
+
+    // accessors
+        // PID of process which terminated
+    int GetPid() { return m_pid; }
+
+        // the exit code
+    int GetExitCode() { return m_exitcode; }
+
+public:
+    int m_pid, m_exitcode;
+};
+
+// A wxProcess object should be passed to wxExecute - than its OnTerminate()
+// function will be called when the process terminates.
 class WXDLLEXPORT wxProcess : public wxEvtHandler
 {
 DECLARE_DYNAMIC_CLASS(wxProcess)
+
 public:
-
     wxProcess(wxEvtHandler *parent = (wxEvtHandler *) NULL, int id = -1);
-  virtual ~wxProcess();
 
-  virtual void OnTerminate(int pid);
+    virtual void OnTerminate(int pid, int status);
 
 protected:
     int m_id;
 };
 
-// Process Event handling
-
-class WXDLLEXPORT wxProcessEvent: public wxEvent
-{
-  DECLARE_DYNAMIC_CLASS(wxProcessEvent)
- public:
-
-  wxProcessEvent(int id = 0, int pid = -1);
-  
-  inline int GetPid() { return m_pid; }
-  inline void SetPid(int pid) { m_pid = pid; }
-
- public:
-  int m_pid;
-};
-
 typedef void (wxObject::*wxProcessEventFunction)(wxProcessEvent&);
 
-#define EVT_END_PROCESS(id, func) { wxEVT_END_PROCESS, id, -1, (wxObjectEvent) (wxEventFunction) (wxProcessEventFunction) & fn, NULL},
+#define EVT_END_PROCESS(id, func) { wxEVT_END_PROCESS, id, -1, (wxObjectEventFunction) (wxEventFunction) (wxProcessEventFunction) & func, NULL},
 
 #endif
     // _WX_PROCESSH__

src/common/process.cpp

@@ -34,24 +34,14 @@ IMPLEMENT_DYNAMIC_CLASS(wxProcessEvent, wxEvent)
 wxProcess::wxProcess(wxEvtHandler *parent, int id)
 {
   if (parent)
-    SetPreviousHandler(parent);
+    SetNextHandler(parent);
 
   m_id = id;
 }
 
-wxProcess::~wxProcess()
+void wxProcess::OnTerminate(int pid, int status)
 {
-}
-
-void wxProcess::OnTerminate(int pid)
-{
-  wxProcessEvent event(m_id, pid);
+  wxProcessEvent event(m_id, pid, status);
 
   ProcessEvent(event);
 }
-
-wxProcessEvent::wxProcessEvent(int id, int pid):
-  wxEvent(id), m_pid(pid)
-{
-}
-

src/gtk.inc

@@ -67,6 +67,7 @@ LIB_CPP_SRC=\
  common/tokenzr.cpp \
  common/resource.cpp \
  common/wxexpr.cpp \
+ common/process.cpp \
 \
  gtk/accel.cpp \
  gtk/app.cpp \

src/gtk/utilsgtk.cpp

@@ -18,6 +18,8 @@
 #include "wx/intl.h"
 #include "wx/log.h"
 
+#include "wx/process.h"
+
 #include <stdarg.h>
 #include <dirent.h>
 #include <string.h>
@@ -266,17 +268,21 @@ static void GTK_EndProcessDetector(gpointer data, gint source,
     /* wait4 is not part of any standard, use at own risk
      * not sure what wait4 does, but wait3 seems to be closest, whats a digit ;-)
      * --- offer@sgi.com */
+    // VZ: wait4() will be woken up by a signal, not wait3 - so it's quite
+    //     different (also, wait3() waits for any child, wait4() only for this
+    //     one)
+    int status = -1;
 #if !defined(__sgi)
-    wait4(proc_data->pid, (int*) NULL, 0, (rusage *) NULL);
+    wait4(proc_data->pid, &status, 0, (rusage *) NULL);
 #else
-    wait3((int *) NULL, 0, (rusage *) NULL);
+    wait3(&status, 0, (rusage *) NULL);
 #endif
 
     close(source);
     gdk_input_remove(proc_data->tag);
 
     if (proc_data->process)
-        proc_data->process->OnTerminate(proc_data->pid);
+        proc_data->process->OnTerminate(proc_data->pid, status);
 
     if (proc_data->pid > 0)
         delete proc_data;

src/gtk1/utilsgtk.cpp

@@ -18,6 +18,8 @@
 #include "wx/intl.h"
 #include "wx/log.h"
 
+#include "wx/process.h"
+
 #include <stdarg.h>
 #include <dirent.h>
 #include <string.h>
@@ -266,17 +268,21 @@ static void GTK_EndProcessDetector(gpointer data, gint source,
     /* wait4 is not part of any standard, use at own risk
      * not sure what wait4 does, but wait3 seems to be closest, whats a digit ;-)
      * --- offer@sgi.com */
+    // VZ: wait4() will be woken up by a signal, not wait3 - so it's quite
+    //     different (also, wait3() waits for any child, wait4() only for this
+    //     one)
+    int status = -1;
 #if !defined(__sgi)
-    wait4(proc_data->pid, (int*) NULL, 0, (rusage *) NULL);
+    wait4(proc_data->pid, &status, 0, (rusage *) NULL);
 #else
-    wait3((int *) NULL, 0, (rusage *) NULL);
+    wait3(&status, 0, (rusage *) NULL);
 #endif
 
     close(source);
     gdk_input_remove(proc_data->tag);
 
     if (proc_data->process)
-        proc_data->process->OnTerminate(proc_data->pid);
+        proc_data->process->OnTerminate(proc_data->pid, status);
 
     if (proc_data->pid > 0)
         delete proc_data;