From 50c90f9174fd2d695e4cb1fdc95283e9c0f465f0 Mon Sep 17 00:00:00 2001 From: Vadim Zeitlin Date: Sat, 12 Jan 2019 15:35:44 +0100 Subject: [PATCH] Use wxScopedPtr<> in URL unit test Don't leak the stream if an error happens in the rest of the test. --- tests/uris/url.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/uris/url.cpp b/tests/uris/url.cpp index 8fbb208927..0520a8be99 100644 --- a/tests/uris/url.cpp +++ b/tests/uris/url.cpp @@ -22,6 +22,7 @@ #include "wx/url.h" #include "wx/mstream.h" +#include "wx/scopedptr.h" // ---------------------------------------------------------------------------- // test class @@ -73,7 +74,7 @@ void URLTestCase::GetInputStream() wxURL url("http://www.wxwidgets.org/assets/img/header-logo.png"); CPPUNIT_ASSERT_EQUAL(wxURL_NOERR, url.GetError()); - wxInputStream *in_stream = url.GetInputStream(); + wxScopedPtr in_stream(url.GetInputStream()); CPPUNIT_ASSERT(in_stream); CPPUNIT_ASSERT(in_stream->IsOk()); @@ -81,9 +82,6 @@ void URLTestCase::GetInputStream() CPPUNIT_ASSERT(in_stream->Read(ostream).GetLastError() == wxSTREAM_EOF); CPPUNIT_ASSERT_EQUAL(17334, ostream.GetSize()); - - // we have to delete the object created by GetInputStream() - delete in_stream; } void URLTestCase::CopyAndAssignment()