Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use a better method of drawing a point in wxGCDC::DrawPoint()

Browse Source 
Drawing a circular point into a square pixel does not completely fill the pixel
with the new color, resulting in an alpha-blended appearance. Instead, draw a
square into the pixel. As a bonus, this is much faster, at least with Cairo.
See #19037
This commit is contained in:
Paul Cornett
2021-01-09 08:39:17 -08:00
parent 108b48f691
commit 4ed8ccff95
1 changed files with 4 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/common/dcgraph.cpp
View File

@@ -776,29 +776,11 @@ void wxGCDCImpl::DoDrawPoint( wxCoord x, wxCoord y )
if (!m_logicalFunctionSupported)
return;
wxPen pointPen(m_pen.GetColour());
wxDCPenChanger penChanger(*GetOwner(), pointPen);
wxDCBrushChanger brushChanger(*GetOwner(), wxBrush(m_pen.GetColour()));
wxDCPenChanger penChanger(*GetOwner(), *wxTRANSPARENT_PEN);
#if defined(__WXMSW__) && wxUSE_GRAPHICS_GDIPLUS
// single point path does not work with GDI+
if (m_graphicContext->GetRenderer() == wxGraphicsRenderer::GetGDIPlusRenderer())
{
const double dx = 0.25 / m_scaleX;
const double dy = 0.25 / m_scaleY;
m_graphicContext->StrokeLine(x - dx, y - dy, x + dx, y + dy);
}
else
#endif
{
#ifdef __WXOSX__
m_graphicContext->StrokeLine(x, y, x, y);
#else
wxGraphicsPath path(m_graphicContext->CreatePath());
path.MoveToPoint(x, y);
path.CloseSubpath();
m_graphicContext->StrokePath(path);
#endif
}
// Raster-based DCs draw a single pixel regardless of scale
m_graphicContext->DrawRectangle(x, y, 1 / m_scaleX, 1 / m_scaleY);
CalcBoundingBox(x, y);
}