Amebis/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

added CreateByName(), use it in wxColourDatabase

Browse Source 
git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@24212 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin
2003-10-17 17:39:28 +00:00
parent 551b5391ae
commit 4e6b83091a
5 changed files with 100 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
include/wx/gtk/colour.h
View File

@@ -80,6 +80,9 @@ public:
unsigned char Blue() const;
// Get colour from name or wxNullColour
static wxColour CreateByName(const wxString& name);
// Implementation part
void CalcPixel( GdkColormap *cmap );
int GetPixel() const;

3
include/wx/gtk1/colour.h
View File

@@ -80,6 +80,9 @@ public:
unsigned char Blue() const;
// Get colour from name or wxNullColour
static wxColour CreateByName(const wxString& name);
// Implementation part
void CalcPixel( GdkColormap *cmap );
int GetPixel() const;

7
src/common/gdicmn.cpp
View File

@@ -409,10 +409,8 @@ wxColour wxColourDatabase::Find(const wxString& colour) const
return *(it->second);
// if we didn't find it, query the system, maybe it knows about it
//
// TODO: move this into platform-specific files
#ifdef __WXGTK__
wxColour col( colour );
#if defined(__WXGTK__) || defined(__X__)
wxColour col = wxColour::CreateByName(colour);
if ( col.Ok() )
{
@@ -422,6 +420,7 @@ wxColour wxColourDatabase::Find(const wxString& colour) const
return col;
#elif defined(__X__)
// TODO: move this to wxColour::CreateByName()
XColor xcolour;
#ifdef __WXMOTIF__

64
src/gtk/colour.cpp
View File

@@ -159,34 +159,44 @@ wxColour::wxColour( unsigned char red, unsigned char green, unsigned char blue )
M_COLDATA->m_color.pixel = 0;
}
/* static */
wxColour wxColour::CreateByName(const wxString& name)
{
wxColour col;
GdkColor colGDK;
if ( gdk_color_parse( wxGTK_CONV( name ), &colGDK ) )
{
wxColourRefData *refData = new wxColourRefData;
refData->m_color = colGDK;
col.m_refData = refData;
}
return col;
}
void wxColour::InitFromName( const wxString &colourName )
{
wxColour* col = NULL;
if ( (wxTheColourDatabase) && (col = wxTheColourDatabase->FindColourNoAdd(colourName)) )
// check the cache first
wxColour col;
if ( wxTheColourDatabase )
{
UnRef();
if (col) Ref( *col );
col = wxTheColourDatabase->Find(colourName);
}
if ( !col.Ok() )
{
col = CreateByName(colourName);
}
if ( col.Ok() )
{
*this = col;
}
else
{
m_refData = new wxColourRefData();
if (!gdk_color_parse( wxGTK_CONV( colourName ), &M_COLDATA->m_color ))
{
// VZ: asserts are good in general but this one is triggered by
// calling wxColourDatabase::FindColour() with an
// unrecognized colour name and this can't be avoided from the
// user code, so don't give it here
//
// a better solution would be to changed code in FindColour()
//wxFAIL_MSG( wxT("wxColour: couldn't find colour") );
delete m_refData;
m_refData = (wxObjectRefData *) NULL;
}
wxFAIL_MSG( wxT("wxColour: couldn't find colour") );
}
}
@@ -196,17 +206,17 @@ wxColour::~wxColour()
bool wxColour::operator == ( const wxColour& col ) const
{
if (m_refData == col.m_refData) return TRUE;
if (m_refData == col.m_refData)
return TRUE;
if (!m_refData || !col.m_refData) return FALSE;
if (!m_refData || !col.m_refData)
return FALSE;
GdkColor *own = &(((wxColourRefData*)m_refData)->m_color);
GdkColor *other = &(((wxColourRefData*)col.m_refData)->m_color);
if (own->red != other->red) return FALSE;
if (own->blue != other->blue) return FALSE;
if (own->green != other->green) return FALSE;
return TRUE;
return own->red == other->red &&
own->blue == other->blue &&
own->green == other->green;
}
wxObjectRefData *wxColour::CreateRefData() const

64
src/gtk1/colour.cpp
View File

@@ -159,34 +159,44 @@ wxColour::wxColour( unsigned char red, unsigned char green, unsigned char blue )
M_COLDATA->m_color.pixel = 0;
}
/* static */
wxColour wxColour::CreateByName(const wxString& name)
{
wxColour col;
GdkColor colGDK;
if ( gdk_color_parse( wxGTK_CONV( name ), &colGDK ) )
{
wxColourRefData *refData = new wxColourRefData;
refData->m_color = colGDK;
col.m_refData = refData;
}
return col;
}
void wxColour::InitFromName( const wxString &colourName )
{
wxColour* col = NULL;
if ( (wxTheColourDatabase) && (col = wxTheColourDatabase->FindColourNoAdd(colourName)) )
// check the cache first
wxColour col;
if ( wxTheColourDatabase )
{
UnRef();
if (col) Ref( *col );
col = wxTheColourDatabase->Find(colourName);
}
if ( !col.Ok() )
{
col = CreateByName(colourName);
}
if ( col.Ok() )
{
*this = col;
}
else
{
m_refData = new wxColourRefData();
if (!gdk_color_parse( wxGTK_CONV( colourName ), &M_COLDATA->m_color ))
{
// VZ: asserts are good in general but this one is triggered by
// calling wxColourDatabase::FindColour() with an
// unrecognized colour name and this can't be avoided from the
// user code, so don't give it here
//
// a better solution would be to changed code in FindColour()
//wxFAIL_MSG( wxT("wxColour: couldn't find colour") );
delete m_refData;
m_refData = (wxObjectRefData *) NULL;
}
wxFAIL_MSG( wxT("wxColour: couldn't find colour") );
}
}
@@ -196,17 +206,17 @@ wxColour::~wxColour()
bool wxColour::operator == ( const wxColour& col ) const
{
if (m_refData == col.m_refData) return TRUE;
if (m_refData == col.m_refData)
return TRUE;
if (!m_refData || !col.m_refData) return FALSE;
if (!m_refData || !col.m_refData)
return FALSE;
GdkColor *own = &(((wxColourRefData*)m_refData)->m_color);
GdkColor *other = &(((wxColourRefData*)col.m_refData)->m_color);
if (own->red != other->red) return FALSE;
if (own->blue != other->blue) return FALSE;
if (own->green != other->green) return FALSE;
return TRUE;
return own->red == other->red &&
own->blue == other->blue &&
own->green == other->green;
}
wxObjectRefData *wxColour::CreateRefData() const